# \[PATCH\] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2016/08/4813577/t

## \[PATCH\] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

- From: Paul Gortmaker \<hidden\>
- Date: 2016-08-14 09:21:04 
- Message: https://ratatoskr.run/linux-fbdev/2016/08/4813577.md

```text
In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
print error when adding adapter fails") the users of the variable
were removed, resulting in:

drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
  int ret;
      ^

...so here we remove the variable as well.

Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
Cc: Wolfram Sang <redacted>
Cc: Tomi Valkeinen <redacted>
Signed-off-by: Paul Gortmaker <redacted>
---

[Feel free to squash this into the original if you happen to be rebasing]

 drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d206857e3e..ba96c44f2761 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
 
 int mb862xx_i2c_init(struct mb862xxfb_par *par)
 {
-	int ret;
-
 	mb862xx_i2c_adapter.algo_data = par;
 	par->adap = &mb862xx_i2c_adapter;
 
-- 
2.8.4

```

## Re: \[PATCH\] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

- From: Wolfram Sang \<hidden\>
- Date: 2016-08-14 12:02:04 
- Message: https://ratatoskr.run/linux-fbdev/2016/08/4813894.md

```text
On Sat, Aug 13, 2016 at 02:39:13PM -0400, Paul Gortmaker wrote:
> In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
> print error when adding adapter fails") the users of the variable
> were removed, resulting in:
> 
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
>   int ret;
>       ^
> 
> ...so here we remove the variable as well.
> 
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
> Cc: Wolfram Sang <redacted>
> Cc: Tomi Valkeinen <redacted>
> Signed-off-by: Paul Gortmaker <redacted>
> ---

Acked-by: Wolfram Sang <redacted>

Thanks! I wonder how this slipped through my and the buildbot checks.
Will investigate...

```