# Re: \[PATCH\] omapfb/dss: wait\_for\_completion\_interruptible\_timeout expects long

- From: Nicholas Mc Guire \<hidden\>
- Date: 2016-08-10 18:48:08 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2016/08/4811335
- Thread: https://ratatoskr.run/linux-omap/2016/07/4801193/t.md

```text
On Wed, Aug 10, 2016 at 01:21:46PM +0300, Tomi Valkeinen wrote:
> On 25/07/16 20:12, Nicholas Mc Guire wrote:
> > wait_for_completion_timeout_interruptible returns long not unsigned long.
> > an appropriately typed variable is introduced and assignments fixed up.
> > 
> > Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> > 
> > Signed-off-by: Nicholas Mc Guire <redacted>
> > ---
> > 
> > API non-compliance was located by coccinelle
> > 
> > This is mostly cosmetic since the returned value is only compared 
> > at present, however if remaining time (completion occurred) where ever 
> > used, then a signal received would be interpreted as a large remaining 
> > jiffies left, which would be wrong.
> > 
> > Compile tested with: omap2plus_defconfig (implies CONFIG_FB_OMAP2_DSS)
> > 
> > Patch is against 4.7.0-rc7 (localversion-next -next-20160724)
> > 
> >  drivers/video/fbdev/omap2/omapfb/dss/dispc-compat.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Thanks, queued for v4.9. I dropped the "Fixes: " line, as that commit
> only does a copy of the files, so the commit didn't really introduce the
> bug.
>
sorry for the wrong fixes tag - did not notice that - and thanks for
fixing this.

thx!
hofrat
```