# \[PATCH\] video: don't print error when adding adapter fails - List: linux-fbdev - 4 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2016/08/4810384/t ## \[PATCH\] video: don't print error when adding adapter fails - From: Wolfram Sang \ - Date: 2016-08-09 11:27:49 - Message: https://ratatoskr.run/linux-fbdev/2016/08/4810384.md ```text Since v4.8-rc1, the I2C core will print detailed information when adding an I2C adapter fails. So, drivers can skip this now. Should go via subsystem tree, I'd think. Wolfram Sang (1): video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.8.1 ``` ## \[PATCH\] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails - From: Wolfram Sang \ - Date: 2016-08-09 11:27:51 - Message: https://ratatoskr.run/linux-fbdev/2016/08/4810383.md ```text The core will do this for us now. Signed-off-by: Wolfram Sang --- drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c index c87e17afb3e2c9..76d206857e3e2c 100644 --- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c +++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c @@ -162,12 +162,7 @@ int mb862xx_i2c_init(struct mb862xxfb_par *par) mb862xx_i2c_adapter.algo_data = par; par->adap = &mb862xx_i2c_adapter; - ret = i2c_add_adapter(par->adap); - if (ret < 0) { - dev_err(par->dev, "failed to add %s\n", - mb862xx_i2c_adapter.name); - } - return ret; + return i2c_add_adapter(par->adap); } void mb862xx_i2c_exit(struct mb862xxfb_par *par) -- 2.8.1 ``` ## Re: \[PATCH\] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails - From: Wolfram Sang \ - Date: 2016-08-10 18:02:09 - Message: https://ratatoskr.run/linux-fbdev/2016/08/4811102.md ```text > One comment: the patch description should be "stand-alone" text, not a > continuation of the subject. I fixed this. I see. Will keep that in mind for the future. Thanks! ``` ## Re: \[PATCH\] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails - From: Tomi Valkeinen \ - Date: 2016-08-10 19:11:22 - Message: https://ratatoskr.run/linux-fbdev/2016/08/4811432.md ```text On 09/08/16 14:27, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- > drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Thanks, queued for v4.9. One comment: the patch description should be "stand-alone" text, not a continuation of the subject. I fixed this. Tomi ```