# Re: \[PATCH -next\] video: ARM CLCD: fix return value check in versatile\_clcd\_init\_panel()

- From: Linus Walleij \<hidden\>
- Date: 2016-08-19 09:07:03 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2016/08/13466585
- Thread: https://ratatoskr.run/linux-fbdev/2016/08/13466584/t.md

```text
On Sat, Aug 13, 2016 at 3:26 AM, Wei Yongjun [ref] wrote:

> In case of error, the function syscon_node_to_regmap() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: 25348160e9a4 ("video: ARM CLCD: add special panel hook for Versatiles")
> Signed-off-by: Wei Yongjun <redacted>

Reviewed-by: Linus Walleij <redacted>

Thanks for fixing my stupid mistake Wei!

Yours,
Linus Walleij
```