# Re: \[PATCHv2\] fbdev: ssd1307fb: Fix charge pump setting

- List: linux-fbdev
- 1 message, 1 author
- Page: https://ratatoskr.run/linux-fbdev/2016/05/13466560/t

## Re: \[PATCHv2\] fbdev: ssd1307fb: Fix charge pump setting

- From: Tomi Valkeinen \<hidden\>
- Date: 2016-05-10 10:30:52 
- Message: https://ratatoskr.run/linux-fbdev/2016/05/13466560.md

```text
Hi,

On 24/03/16 23:14, Julian Scheel wrote:
> Make sure bit 4 is set for the charge pump setting. It is required according
> to SSD1306 App Note.
> 
> Signed-off-by: Julian Scheel <redacted>
> ---
> Changes in v2:
> - Simplify commit message
> - Use BIT macros to increase readability
> ---
>  drivers/video/fbdev/ssd1307fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 1611215..3b9ee0c 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -389,7 +389,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
>  		return ret;
>  
>  	ret = ssd1307fb_write_cmd(par->client,
> -		(par->device_info->need_chargepump & 0x1 << 2) & 0x14);
> +		BIT(4) | (par->device_info->need_chargepump ? BIT(2) : 0));
>  	if (ret < 0)
>  		return ret;

Thanks, queued for 4.7.

 Tomi

```
