# Re: \[PATCH 1/3\] video: fbdev: imxfb: fix semantic of .get\_power and .set\_power

- From: Uwe Kleine-König \<hidden\>
- Date: 2016-03-08 08:30:52 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2016/03/8731520
- Thread: https://ratatoskr.run/linux-arm-kernel/2016/03/8731490/t.md

```text
Hello,

On Tue, Mar 08, 2016 at 08:55:30AM +0100, Philipp Zabel wrote:
> Hi Uwe,
> 
> Am Montag, den 07.03.2016, 20:53 +0100 schrieb Uwe Kleine-König:
> > .set_power gets passed an FB_BLANK_XXX value, not a bool. So 0 signals
> > on; and >1 means off. The same applies for return values of .get_power.
> 
> I'd try to somehow work this information into the code to avoid future
> confusion.

I integrated your changes into my code, you're obviously right here.

Jean-Christophe, Tomi: Do you agree in principle with these changes? If
so I can resend. If you won't take the changes anyhow, I wouldn't.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
```