[PATCHv2] fbdev: ssd1307fb: Fix charge pump setting
From: Julian Scheel <hidden>
Date: 2016-03-24 21:14:23
Subsystem:
framebuffer layer, the rest · Maintainers:
Helge Deller, Linus Torvalds
From: Julian Scheel <hidden>
Date: 2016-03-24 21:14:23
Subsystem:
framebuffer layer, the rest · Maintainers:
Helge Deller, Linus Torvalds
Make sure bit 4 is set for the charge pump setting. It is required according to SSD1306 App Note. Signed-off-by: Julian Scheel <redacted> --- Changes in v2: - Simplify commit message - Use BIT macros to increase readability --- drivers/video/fbdev/ssd1307fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 1611215..3b9ee0c 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c@@ -389,7 +389,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) return ret; ret = ssd1307fb_write_cmd(par->client, - (par->device_info->need_chargepump & 0x1 << 2) & 0x14); + BIT(4) | (par->device_info->need_chargepump ? BIT(2) : 0)); if (ret < 0) return ret;
--
2.7.0