# \[PATCH 0/9\] Change return type of of\_clk\_get\_parent\_count() to unsigned - Subsystems: FRAMEBUFFER LAYER, SIMPLEFB FB DRIVER, ARM/Allwinner SoC Clock Support, COMMON CLK FRAMEWORK, DESIGNWARE USB3 DRD IP DRIVER, THE REST, TI CLOCK DRIVER, USB SUBSYSTEM - Maintainers: Helge Deller, Hans de Goede, Emilio López, Stephen Boyd, Brian Masney, Jerome Brunet, Thinh Nguyen, Linus Torvalds, Tero Kristo, Greg Kroah-Hartman - Series: 9 patches touching 21 files, +56/-45 - List: linux-fbdev - 3 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2016/02/4691061/t ## \[PATCH 0/9\] Change return type of of\_clk\_get\_parent\_count() to unsigned - From: Stephen Boyd \ - Date: 2016-02-22 20:54:54 - Message: https://ratatoskr.run/linux-fbdev/2016/02/4691061.md ```text Russell King recently pointed out that of_clk_get_parent_count() can return a negative number if the "clocks" property isn't present in a node. Upon investigating all the callers of this API, none of the them seem to care about that case, and furthermore some callers are assigning the return value to an unsigned int which could cause very large numbers of parents to be used. This series changes the API to return an unsigned int from 0 (no parents) to N, thereby avoiding any problems with negative return values. Cc: Boris Brezillon Cc: Yoshinori Sato Cc: Cc: Gabriel Fernandez Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Tero Kristo Cc: Felipe Balbi Cc: Cc: Hans de Goede Cc: Jean-Christophe Plagniol-Villard Cc: Tomi Valkeinen Cc: Stephen Boyd (9): clk: Make of_clk_get_parent_count() return unsigned ints clk: at91: Remove impossible checks for of_clk_get_parent_count() clk: gpio: Remove impossible check for of_clk_get_parent_count() < 0 clk: h8300: Remove impossible check for of_clk_get_parent_count() clk: st: Remove impossible check for of_clk_get_parent_count() < 0 clk: sunxi: Use proper type for of_clk_get_parent_count() return value clk: ti: Update for of_clk_get_parent_count() returning unsigned int usb: dwc3: Remove impossible check for of_clk_get_parent_count() < 0 simplefb: Remove impossible check for of_clk_get_parent_count() < 0 drivers/clk/at91/clk-generated.c | 4 ++-- drivers/clk/at91/clk-main.c | 4 ++-- drivers/clk/at91/clk-master.c | 4 ++-- drivers/clk/at91/clk-programmable.c | 4 ++-- drivers/clk/at91/clk-slow.c | 6 +++--- drivers/clk/at91/clk-smd.c | 4 ++-- drivers/clk/at91/clk-usb.c | 4 ++-- drivers/clk/clk-gpio.c | 6 ++---- drivers/clk/clk.c | 16 ++++++++++++++-- drivers/clk/h8300/clk-div.c | 4 ++-- drivers/clk/h8300/clk-h8s2678.c | 4 ++-- drivers/clk/st/clk-flexgen.c | 4 ++-- drivers/clk/st/clkgen-mux.c | 4 ++-- drivers/clk/sunxi/clk-sun6i-ar100.c | 2 +- drivers/clk/ti/clockdomain.c | 2 +- drivers/clk/ti/composite.c | 8 ++++---- drivers/clk/ti/dpll.c | 2 +- drivers/clk/ti/mux.c | 4 ++-- drivers/usb/dwc3/dwc3-of-simple.c | 9 +++++---- drivers/video/fbdev/simplefb.c | 4 ++-- include/linux/clk-provider.h | 2 +- 21 files changed, 56 insertions(+), 45 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ``` ## \[PATCH 9/9\] simplefb: Remove impossible check for of\_clk\_get\_parent\_count() \< 0 - From: Stephen Boyd \ - Date: 2016-02-22 20:55:42 - Message: https://ratatoskr.run/linux-fbdev/2016/02/4691062.md ```text The check for < 0 is impossible now that of_clk_get_parent_count() returns an unsigned int. Simplify the code and update the types. Cc: Hans de Goede Cc: Jean-Christophe Plagniol-Villard Cc: Tomi Valkeinen Cc: Signed-off-by: Stephen Boyd --- Please ack so this can go through clk tree along with patch 1. drivers/video/fbdev/simplefb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index 48ccf6db62a2..e9cf19977285 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -174,7 +174,7 @@ static int simplefb_parse_pd(struct platform_device *pdev, struct simplefb_par { u32 palette[PSEUDO_PALETTE_SIZE]; #if defined CONFIG_OF && defined CONFIG_COMMON_CLK - int clk_count; + unsigned int clk_count; struct clk **clks; #endif #if defined CONFIG_OF && defined CONFIG_REGULATOR @@ -213,7 +213,7 @@ static int simplefb_clocks_init(struct simplefb_par *par, return 0; par->clk_count = of_clk_get_parent_count(np); - if (par->clk_count <= 0) + if (!par->clk_count) return 0; par->clks = kcalloc(par->clk_count, sizeof(struct clk *), GFP_KERNEL); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ``` ## Re: \[PATCH 9/9\] simplefb: Remove impossible check for of\_clk\_get\_parent\_count() \< 0 - From: Tomi Valkeinen \ - Date: 2016-02-26 11:35:37 - Message: https://ratatoskr.run/linux-fbdev/2016/02/4695326.md ```text On 22/02/16 22:54, Stephen Boyd wrote: > The check for < 0 is impossible now that > of_clk_get_parent_count() returns an unsigned int. Simplify the > code and update the types. > > Cc: Hans de Goede > Cc: Jean-Christophe Plagniol-Villard > Cc: Tomi Valkeinen > Cc: > Signed-off-by: Stephen Boyd > --- > > Please ack so this can go through clk tree along with patch 1. > > drivers/video/fbdev/simplefb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Tomi Valkeinen Tomi ```