[PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

Subsystems: framebuffer layer, the rest

STALE3825d

8 messages, 5 authors, 2016-02-26 · open the first message on its own page

[PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Simon Horman <hidden>
Date: 2016-02-22 01:59:51

Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
---
 drivers/video/fbdev/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on v4.5-rc1
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5cd806..936ebd4bcf73 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1985,7 +1985,7 @@ config FB_W100
 
 config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
-	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on FB && (SUPERH || ARCH_RENESAS) && HAVE_CLK
 	depends on FB_SH_MOBILE_MERAM || !FB_SH_MOBILE_MERAM
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
-- 
2.1.4

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-02-22 09:27:07

On Mon, Feb 22, 2016 at 2:59 AM, Simon Horman
[off-list ref] wrote:
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2016-02-22 12:24:25

Hi Simon,

Thank you for the patch.

On Monday 22 February 2016 10:59:51 Simon Horman wrote:
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
Wouldn't it make sense to drop the driver instead ? We have a DRM driver that 
replaces it.
quoted hunk
---
 drivers/video/fbdev/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on v4.5-rc1
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5cd806..936ebd4bcf73 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1985,7 +1985,7 @@ config FB_W100

 config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
-	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on FB && (SUPERH || ARCH_RENESAS) && HAVE_CLK
 	depends on FB_SH_MOBILE_MERAM || !FB_SH_MOBILE_MERAM
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
-- 
Regards,

Laurent Pinchart

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-02-22 12:39:37

Hi Laurent,

On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart
[off-list ref] wrote:
On Monday 22 February 2016 10:59:51 Simon Horman wrote:
quoted
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
Wouldn't it make sense to drop the driver instead ? We have a DRM driver that
replaces it.
Does the DRM driver work on all hardware supported by the fbdev driver?
It's not only used on r8a7740/armadillo (through staging/board due to lack of
DT support), but also on many SH boards.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2016-02-22 13:05:58

Hi Geert,

On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote:
On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote:
quoted
On Monday 22 February 2016 10:59:51 Simon Horman wrote:
quoted
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a
more appropriate name than SHMOBILE for the majority of Renesas ARM based
SoCs.

Signed-off-by: Simon Horman <redacted>
Wouldn't it make sense to drop the driver instead ? We have a DRM driver
that replaces it.
Does the DRM driver work on all hardware supported by the fbdev driver?
It's not only used on r8a7740/armadillo (through staging/board due to lack
of DT support), but also on many SH boards.
It's supposed to be a replacement (lacking support for SYS panels though), but 
has obviously not been tested on SH boards.

-- 
Regards,

Laurent Pinchart

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Simon Horman <horms@verge.net.au>
Date: 2016-02-23 00:11:03

On Mon, Feb 22, 2016 at 03:05:58PM +0200, Laurent Pinchart wrote:
Hi Geert,

On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote:
quoted
On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote:
quoted
On Monday 22 February 2016 10:59:51 Simon Horman wrote:
quoted
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a
more appropriate name than SHMOBILE for the majority of Renesas ARM based
SoCs.

Signed-off-by: Simon Horman <redacted>
Wouldn't it make sense to drop the driver instead ? We have a DRM driver
that replaces it.
Does the DRM driver work on all hardware supported by the fbdev driver?
It's not only used on r8a7740/armadillo (through staging/board due to lack
of DT support), but also on many SH boards.
It's supposed to be a replacement (lacking support for SYS panels though), but 
has obviously not been tested on SH boards.
From my point of view it would be overreach to remove the driver as we
aren't in a position to test the SH boards.

We could stop using it on the Renesas ARM SoCs and in turn remove
ARCH_SHMOBILE/ARCH_RENESAS. Am I right in thinking that would only
effect the r8a7740/armadillo at this time?

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2016-02-23 07:41:32

Hi Simon,

On Tuesday 23 February 2016 09:11:03 Simon Horman wrote:
On Mon, Feb 22, 2016 at 03:05:58PM +0200, Laurent Pinchart wrote:
quoted
On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote:
quoted
On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote:
quoted
On Monday 22 February 2016 10:59:51 Simon Horman wrote:
quoted
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be
a more appropriate name than SHMOBILE for the majority of Renesas ARM
based SoCs.

Signed-off-by: Simon Horman <redacted>
Wouldn't it make sense to drop the driver instead ? We have a DRM
driver that replaces it.
Does the DRM driver work on all hardware supported by the fbdev driver?
It's not only used on r8a7740/armadillo (through staging/board due to
lack of DT support), but also on many SH boards.
It's supposed to be a replacement (lacking support for SYS panels though),
but has obviously not been tested on SH boards.
From my point of view it would be overreach to remove the driver as we
aren't in a position to test the SH boards.
I'd be surprised if the driver still worked on those boards, but I like good 
surprises :-)
We could stop using it on the Renesas ARM SoCs and in turn remove
ARCH_SHMOBILE/ARCH_RENESAS. Am I right in thinking that would only
effect the r8a7740/armadillo at this time?
That's correct.

-- 
Regards,

Laurent Pinchart

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

From: Tomi Valkeinen <hidden>
Date: 2016-02-26 11:00:18


On 22/02/16 03:59, Simon Horman wrote:
quoted hunk
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
---
 drivers/video/fbdev/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on v4.5-rc1
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5cd806..936ebd4bcf73 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1985,7 +1985,7 @@ config FB_W100
 
 config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
-	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on FB && (SUPERH || ARCH_RENESAS) && HAVE_CLK
 	depends on FB_SH_MOBILE_MERAM || !FB_SH_MOBILE_MERAM
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
Thanks, queued for 4.6.

 Tomi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help