[PATCH] staging: sm750fb: cleanup: fix brace placement

Subsystems: staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest

STALE3853d

3 messages, 2 authors, 2016-01-24 · open the first message on its own page

[PATCH] staging: sm750fb: cleanup: fix brace placement

From: Charles Rose <hidden>
Date: 2016-01-19 23:42:15

Fix brace placement warnings caught by checkpatch.pl.

Signed-off-by: Charles Rose <redacted>
---
 drivers/staging/sm750fb/sm750_cursor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index 3b7ce92..cab891c 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -143,8 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
 		iowrite16(data, pbuffer);
 
 		/* assume pitch is 1,2,4,8,...*/
-		if ((i+1) % pitch = 0)
-		{
+		if ((i+1) % pitch = 0) {
 			/* need a return */
 			pstart += offset;
 			pbuffer = pstart;
-- 
2.5.0

Re: [PATCH] staging: sm750fb: cleanup: fix brace placement

From: Charles Rose <hidden>
Date: 2016-01-22 18:45:18

On 01/19/2016 06:42 PM, Charles Rose wrote:
quoted hunk
Fix brace placement warnings caught by checkpatch.pl.

Signed-off-by: Charles Rose <redacted>
---
  drivers/staging/sm750fb/sm750_cursor.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index 3b7ce92..cab891c 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -143,8 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
  		iowrite16(data, pbuffer);

  		/* assume pitch is 1,2,4,8,...*/
-		if ((i+1) % pitch = 0)
-		{
+		if ((i+1) % pitch = 0) {
  			/* need a return */
  			pstart += offset;
  			pbuffer = pstart;
Missed copying Greg KH on this.

Thanks,
Charles

Re: [PATCH] staging: sm750fb: cleanup: fix brace placement

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2016-01-24 20:50:46

On Fri, Jan 22, 2016 at 01:45:18PM -0500, Charles Rose wrote:
On 01/19/2016 06:42 PM, Charles Rose wrote:
quoted
Fix brace placement warnings caught by checkpatch.pl.

Signed-off-by: Charles Rose <redacted>
---
 drivers/staging/sm750fb/sm750_cursor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index 3b7ce92..cab891c 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -143,8 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
 		iowrite16(data, pbuffer);

 		/* assume pitch is 1,2,4,8,...*/
-		if ((i+1) % pitch = 0)
-		{
+		if ((i+1) % pitch = 0) {
 			/* need a return */
 			pstart += offset;
 			pbuffer = pstart;
Missed copying Greg KH on this.
I can't do anything with a forwarded patch like this :(
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help