# Re: \[PATCH v3\] video: fbdev: fsl: Fix kernel crash when diu\_ops is not implemented

- From: Scott Wood \<hidden\>
- Date: 2015-12-07 17:07:22 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2015/12/13466424
- Thread: https://ratatoskr.run/linux-fbdev/2015/12/13466421/t.md

```text
On Thu, 2015-12-03 at 09:54 +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <redacted>
> 
> If diu_ops is not implemented on platform, kernel will access a NULL
> pointer. We need to check this pointer in DIU initialization.
> 
> Signed-off-by: Wang Dongsheng <redacted>
> ---
> v3:
> - Fix capitalization in patch description.
> - Add comments for verify diu_ops.set_pixel_clock.
> 
> v2:
> - Move set_pixel_clock judgement to fsl_diu_init.
> 
>  drivers/video/fbdev/fsl-diu-fb.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)

Why did you not CC stable as I previously requested?

-Scott

```
