[PATCH] video:fbdev:core:Calculate the size for colormap only after the validation of length for col
DORMANTno replies
From: Shailendra Verma <hidden>
Date: 2015-11-09 08:07:07
Also in:
lkml
Subsystem:
framebuffer core, framebuffer layer, the rest · Maintainers:
Simona Vetter, Helge Deller, Linus Torvalds
From: Shailendra Verma <redacted> While allocating the memory for color map, the memory size for colors is being calculated before the validation of length for color map. Moved the size calculation part after the validation of color map length. Signed-off-by: Shailendra Verma <redacted> --- drivers/video/fbdev/core/fbcmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbcmap.c b/drivers/video/fbdev/core/fbcmap.c
index f89245b..45ad567 100644
--- a/drivers/video/fbdev/core/fbcmap.c
+++ b/drivers/video/fbdev/core/fbcmap.c@@ -91,7 +91,7 @@ static const struct fb_cmap default_16_colors = { int fb_alloc_cmap_gfp(struct fb_cmap *cmap, int len, int transp, gfp_t flags) { - int size = len * sizeof(u16); + int size; int ret = -ENOMEM; if (cmap->len != len) {
@@ -99,6 +99,7 @@ int fb_alloc_cmap_gfp(struct fb_cmap *cmap, int len, int transp, gfp_t flags) if (!len) return 0; + size = len * sizeof(u16); cmap->red = kmalloc(size, flags); if (!cmap->red) goto fail;
--
1.9.1