# \[PATCH 1/2\] staging: sm750fb: move opening brace to previous line

- Subsystems: STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER, STAGING SUBSYSTEM, THE REST
- Maintainers: Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Greg Kroah-Hartman, Linus Torvalds
- List: linux-fbdev
- 5 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2015/11/4616113/t

## \[PATCH 1/2\] staging: sm750fb: move opening brace to previous line

- From: Othmar Pasteka \<hidden\>
- Date: 2015-11-08 01:00:41 
- Message: https://ratatoskr.run/linux-fbdev/2015/11/4616113.md

```text
Fixes the checkpatch.pl error:
ERROR: that open brace { should be on the previous line

Signed-off-by: Othmar Pasteka <redacted>
---
 drivers/staging/sm750fb/sm750_cursor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index 3b7ce92..cab891c 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -143,8 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
 		iowrite16(data, pbuffer);
 
 		/* assume pitch is 1,2,4,8,...*/
-		if ((i+1) % pitch = 0)
-		{
+		if ((i+1) % pitch = 0) {
 			/* need a return */
 			pstart += offset;
 			pbuffer = pstart;
-- 
2.5.3

```

## \[PATCH 2/2\] staging: sm750fb: add spaces around operator

- From: Othmar Pasteka \<hidden\>
- Date: 2015-11-08 00:59:49 
- Message: https://ratatoskr.run/linux-fbdev/2015/11/4616114.md

```text
checkpatch.pl says: CHECK: spaces preferred around that '+' (ctx:VxV)

Signed-off-by: Othmar Pasteka <redacted>
---
 drivers/staging/sm750fb/sm750_cursor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index cab891c..0a41585 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -143,7 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
 		iowrite16(data, pbuffer);
 
 		/* assume pitch is 1,2,4,8,...*/
-		if ((i+1) % pitch = 0) {
+		if ((i + 1) % pitch = 0) {
 			/* need a return */
 			pstart += offset;
 			pbuffer = pstart;
-- 
2.5.3

```

## Re: \[PATCH 2/2\] staging: sm750fb: add spaces around operator

- From: Dan Carpenter \<hidden\>
- Date: 2015-11-08 06:35:41 
- Message: https://ratatoskr.run/linux-fbdev/2015/11/4616140.md

```text
If it's a one line fix then just send it as a single patch.

regards,
dan carpenter

```

## Re: \[PATCH 2/2\] staging: sm750fb: add spaces around operator

- From: Othmar Pasteka \<hidden\>
- Date: 2015-11-08 07:33:24 
- Message: https://ratatoskr.run/linux-fbdev/2015/11/4616186.md

```text
On Sun, Nov 08, 2015 at 09:35:08AM +0300, Dan Carpenter wrote:
> If it's a one line fix then just send it as a single patch.

It was two things, hence I made it a two-parter.

Should I send a new version or is it a note for next time?

Thanks,
Othmar Pasteka
```

## Re: \[PATCH 2/2\] staging: sm750fb: add spaces around operator

- From: Dan Carpenter \<hidden\>
- Date: 2015-11-08 08:17:51 
- Message: https://ratatoskr.run/linux-fbdev/2015/11/4616199.md

```text
On Sun, Nov 08, 2015 at 08:33:16AM +0100, Othmar Pasteka wrote:
> Should I send a new version or is it a note for next time?

Send a new version.

regards,
dan carpenter

```