[PATCH] video:fbdev:core:Calculate the buffer alignment if buffer is not IO mapped.

DORMANTno replies

From: Shailendra Verma <hidden>
Date: 2015-10-30 11:30:51
Also in: lkml
Subsystem: the rest · Maintainer: Linus Torvalds

From: Shailendra Verma <redacted>

Moving the instruction "align = buf->buf_align - 1" just after the
verification of the buffer if it is IP mapped or not as the buffer
alignment is not required if it is IO mapped.Thus it will save an
extra instuction execution when buffer is IO mapped.

Signed-off-by: Shailendra Verma <redacted>
---
 linux-4.3-rc6/drivers/video/fbdev/core/fbmem.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/linux-4.3-rc6/drivers/video/fbdev/core/fbmem.c b/linux-4.3-rc6/drivers/video/fbdev/core/fbmem.c
index 0705d88..d92ec99 100644
--- a/linux-4.3-rc6/drivers/video/fbdev/core/fbmem.c
+++ b/linux-4.3-rc6/drivers/video/fbdev/core/fbmem.c
@@ -157,7 +157,7 @@ EXPORT_SYMBOL(fb_pad_unaligned_buffer);
  */
 char* fb_get_buffer_offset(struct fb_info *info, struct fb_pixmap *buf, u32 size)
 {
-	u32 align = buf->buf_align - 1, offset;
+	u32 align, offset;
 	char *addr = buf->addr;
 
 	/* If IO mapped, we need to sync before access, no sharing of
@@ -169,6 +169,8 @@ char* fb_get_buffer_offset(struct fb_info *info, struct fb_pixmap *buf, u32 size
 		return addr;
 	}
 
+	align = buf->buf_align - 1;
+
 	/* See if we fit in the remaining pixmap space */
 	offset = buf->offset + align;
 	offset &= ~align;
-- 
1.7.9.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help