[PATCH] video: fbdev: add Marvell PXA framebuffer binding

Subsystems: open firmware and flattened device tree bindings, the rest

STALE4029d

2 messages, 2 authors, 2015-10-03 · open the first message on its own page

[PATCH] video: fbdev: add Marvell PXA framebuffer binding

From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: 2015-10-03 16:17:00

Add documentation for the PXA frambuffer devicetree binding.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Jean-Christophe Plagniol-Villard <redacted>
Cc: Tomi Valkeinen <redacted>
Cc: linux-fbdev@vger.kernel.org

---
 .../devicetree/bindings/video/marvell,pxafb.txt    | 75 ++++++++++++++++++++++
 1 file changed, 75 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/video/marvell,pxafb.txt
diff --git a/Documentation/devicetree/bindings/video/marvell,pxafb.txt b/Documentation/devicetree/bindings/video/marvell,pxafb.txt
new file mode 100644
index 000000000000..489055bf3c57
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/marvell,pxafb.txt
@@ -0,0 +1,75 @@
+PXA LCDC Framebuffer
+-----------------------------------------------------
+
+Required properties:
+- compatible :
+	"marvell,pxa2xx-fb",
+- reg : Should contain 1 register ranges(address and length).
+	Can contain an additional register range(address and length)
+	for fixed framebuffer memory. Useful for dedicated memories.
+- interrupts : framebuffer controller interrupt
+- display: a phandle pointing to the display node
+
+Required nodes:
+- display: a display node is required to initialize the lcd panel
+	   This should be in the board dts.
+- default-mode: a videomode within the display with timing parameters
+		as specified below.
+- bits-per-pixel: pixel data bus width of the LCD panel
+
+Optional properties:
+- lcd-supply: Regulator for LCD supply voltage.
+- enable-transparency-bit: if framebuffer colorspace reserves a bit for
+			   transparency
+- enable-greyscale-cmap: true if palette is a grayscale based instead of color
+
+Example:
+
+	fb0: video@0x44000000 {
+		compatible = "marvell,pxa2xx-fb";
+		reg = <0x44000000 0x10000>;
+		interrupts = <17>;
+		clocks = <&clks CLK_LCD>;
+		interrupts = <23>;
+		display = <&display0>;
+		status = "okay";
+
+		enable-transparency-bit = <0>;
+		enable-greyscale-cmap = <0>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+	};
+
+PXA LCDC Display
+-----------------------------------------------------
+Required properties (as per of_videomode_helper):
+ - lcd-type: either "mono-stn", "mono-dstn", "color-stn", "color-dstn",
+   	     	    "color-tft", "smart-panel"
+ - bits-per-pixel: LCD data bus width
+
+Optional properties (as per of_videomode_helper):
+ - power-regulator: power supply regulator to the LCD to power it on or off
+
+Example:
+	display0: display {
+		lcd-type = "color-tft";
+		bits-per-pixel = <16>;
+
+		display-timings {
+			native-mode = <&timing0>;
+			timing0: 240p {
+				/* 240x320p24 */
+				clock-frequency = <4545000>;
+				hactive = <240>;
+				vactive = <320>;
+				hfront-porch = <4>;
+				hback-porch = <6>;
+				hsync-len = <4>;
+				vback-porch = <5>;
+				vfront-porch = <3>;
+				vsync-len = <2>;
+				pixelclk-active = <0>;
+				de-active = <1>;
+			};
+		};
+	};
-- 
2.1.4

Re: [PATCH] video: fbdev: add Marvell PXA framebuffer binding

From: Philipp Zabel <hidden>
Date: 2015-10-03 17:14:39

On Sat, Oct 3, 2015 at 6:11 PM, Robert Jarzmik [off-list ref] wrote:
quoted hunk
Add documentation for the PXA frambuffer devicetree binding.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Jean-Christophe Plagniol-Villard <redacted>
Cc: Tomi Valkeinen <redacted>
Cc: linux-fbdev@vger.kernel.org

---
 .../devicetree/bindings/video/marvell,pxafb.txt    | 75 ++++++++++++++++++++++
 1 file changed, 75 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/video/marvell,pxafb.txt
diff --git a/Documentation/devicetree/bindings/video/marvell,pxafb.txt b/Documentation/devicetree/bindings/video/marvell,pxafb.txt
new file mode 100644
index 000000000000..489055bf3c57
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/marvell,pxafb.txt
@@ -0,0 +1,75 @@
+PXA LCDC Framebuffer
+-----------------------------------------------------
+
+Required properties:
+- compatible :
+       "marvell,pxa2xx-fb",
Should be "marvell,pxa2xx-lcd-controller", "marvell,pxa2xx-lcdc" or
something like this.
quoted hunk
+- reg : Should contain 1 register ranges(address and length).
+       Can contain an additional register range(address and length)
+       for fixed framebuffer memory. Useful for dedicated memories.
+- interrupts : framebuffer controller interrupt
+- display: a phandle pointing to the display node
+
+Required nodes:
+- display: a display node is required to initialize the lcd panel
+          This should be in the board dts.
I'd prefer to use an of-graph link to a panel node with a proper
compatible value for the panel, instead of this custom display
property.
That way, if somebody ever decides convert the fbdev driver to a drm
driver, we don't have to change the device tree and can directly use
drm_panel.
quoted hunk
+- default-mode: a videomode within the display with timing parameters
+               as specified below.
+- bits-per-pixel: pixel data bus width of the LCD panel
Would bus-width be better here?
+Optional properties:
+- lcd-supply: Regulator for LCD supply voltage.
How does this differ from the regulator below?
+- enable-transparency-bit: if framebuffer colorspace reserves a bit for
+                          transparency
That doesn't belong in the device tree.
+- enable-greyscale-cmap: true if palette is a grayscale based instead of color
I suspect this doesn't belong in the device tree either. Does this
specify the pixel format of the memory framebuffer?
quoted hunk
+Example:
+
+       fb0: video@0x44000000 {
+               compatible = "marvell,pxa2xx-fb";
+               reg = <0x44000000 0x10000>;
+               interrupts = <17>;
+               clocks = <&clks CLK_LCD>;
+               interrupts = <23>;
+               display = <&display0>;
+               status = "okay";
+
+               enable-transparency-bit = <0>;
+               enable-greyscale-cmap = <0>;
+               #address-cells = <1>;
+               #size-cells = <1>;
What are the #address/size-cells needed for?
quoted hunk
+       };
+
+PXA LCDC Display
+-----------------------------------------------------
+Required properties (as per of_videomode_helper):
+ - lcd-type: either "mono-stn", "mono-dstn", "color-stn", "color-dstn",
+                   "color-tft", "smart-panel"
+ - bits-per-pixel: LCD data bus width
This is already found in the lcd controller node above.
+Optional properties (as per of_videomode_helper):
+ - power-regulator: power supply regulator to the LCD to power it on or off
regards
Philipp
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help