# Re: \[PATCH v2 1/3\] staging: sm7xxfb: move sm712fb out of staging

- From: Mike Rapoport \<hidden\>
- Date: 2015-09-27 04:42:34 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2015/09/4584417
- Thread: https://ratatoskr.run/linux-fbdev/2015/09/4567629/t.md

```text
Hi Sudip,

On Fri, Sep 25, 2015 at 07:12:06PM +0530, Sudip Mukherjee wrote:
> On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote:
> > 
> > On 02/09/15 15:48, Sudip Mukherjee wrote:
> > 
> <snip>
> > 
> > Is there a public datasheet for the HW?
> I could not find one in Silicon Motion website. I will try to find else
> I can talk to them and keep it in my github. And can send you also if
> you want.

I'd appreciate sm750 datasheet, if you have one.

> > 
> > The driver as it is now is quite horrible. Huge tables of raw data,
> > written directly to the registers. Lots of magic numbers all around.
> > Even with a datasheet, presuming it's public and it contains all those
> > values, the driver is rather unmaintainable.
> > 
> > All those need to be sorted out for the DRM driver anyway, so maybe it's
> > better to clean up the fb driver first.
> Ok. I never looked at them to see how they can be made better. I will
> see.
> 
> regards
> sudip

--
Sincerely yours,
Mike.
```
