# Re: \[PATCH 1/7\] cpufreq: remove redundant CPUFREQ\_INCOMPATIBLE notifier event

- From: Rafael J. Wysocki \<rafael@kernel.org\>
- Date: 2015-09-10 00:53:24 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2015/09/4572643
- Thread: https://ratatoskr.run/linux-pm/2015/08/9302266/t.md

```text
Hi,

On Thu, Sep 10, 2015 at 2:39 AM, Viresh Kumar [ref] wrote:
> On 10-09-15, 01:26, Rafael J. Wysocki wrote:
>> On Monday, August 03, 2015 08:36:14 AM Viresh Kumar wrote:
>> > What's being done from CPUFREQ_INCOMPATIBLE, can also be done with
>> > CPUFREQ_ADJUST. There is nothing special with CPUFREQ_INCOMPATIBLE
>> > notifier.
>>
>> The above part of the changelog is a disaster to me. :-(
>>
>> It not only doesn't explain what really goes on, but it's actively confusing.
>>
>> What really happens is that the core sends CPUFREQ_INCOMPATIBLE notifications
>> unconditionally right after sending the CPUFREQ_ADJUST ones, so the former is
>> just redundant and it's more efficient to merge the two into one.
>
> Undoubtedly this looks far better :)
>
> But, isn't this series already applied some time back ?

Right, never mind.  For some reason that patch was left in the "New" state.

The code is OK.

Thanks,
Rafael
```