# \[PATCH v2 0/2\] OMAPDSS: Fix of-node refcount issues

- Revision v2 (2 revisions archived).
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2015/08/13466317/t

## \[PATCH v2 0/2\] OMAPDSS: Fix of-node refcount issues

- From: Jyri Sarha \<hidden\>
- Date: 2015-08-07 11:04:28 
- Message: https://ratatoskr.run/linux-fbdev/2015/08/13466317.md

```text
Changes since the first version:
- Fix commit descriptions and subject according to Tomi's comments

I found couple of refcounting issues related to OMAP DSS of-node
handling. Second patch should fix the "ERROR: Bad of_node_put() on
/encoder@0/ports/port@1" -problem.

In the long run it would make sense start using of_graph_*() functions
in OMAP DSS too. However the semantics of of_graph_*() functions are
quite different from omapdss_of_*() counterparts. So it better to just
fix these bugs first.

Jyri Sarha (2):
  OMAPDSS: Fix node refcount leak in omapdss_of_get_next_port()
  OMAPDSS: Fix omap_dss_find_output_by_port_node() port refcount
    decrement

 drivers/video/fbdev/omap2/dss/dss-of.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.1

```

## Re: \[PATCH v2 0/2\] OMAPDSS: Fix of-node refcount issues

- From: Tomi Valkeinen \<hidden\>
- Date: 2015-08-10 09:23:21 
- Message: https://ratatoskr.run/linux-fbdev/2015/08/13466318.md

```text


On 07/08/15 14:04, Jyri Sarha wrote:
> Changes since the first version:
> - Fix commit descriptions and subject according to Tomi's comments
> 
> I found couple of refcounting issues related to OMAP DSS of-node
> handling. Second patch should fix the "ERROR: Bad of_node_put() on
> /encoder@0/ports/port@1" -problem.
> 
> In the long run it would make sense start using of_graph_*() functions
> in OMAP DSS too. However the semantics of of_graph_*() functions are
> quite different from omapdss_of_*() counterparts. So it better to just
> fix these bugs first.
> 
> Jyri Sarha (2):
>   OMAPDSS: Fix node refcount leak in omapdss_of_get_next_port()
>   OMAPDSS: Fix omap_dss_find_output_by_port_node() port refcount
>     decrement
> 
>  drivers/video/fbdev/omap2/dss/dss-of.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, I've picked these up for 4.2 fixes.

 Tomi

```