# \[PATCH 1/2\] OMAPDSS: dss-of: Fix node refcount leak in omapdss\_of\_get\_next\_port() - Subsystems: FRAMEBUFFER LAYER, OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT (DSS2), THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2015/08/13466303/t ## \[PATCH 1/2\] OMAPDSS: dss-of: Fix node refcount leak in omapdss\_of\_get\_next\_port() - From: Jyri Sarha \ - Date: 2015-08-06 18:41:24 - Message: https://ratatoskr.run/linux-fbdev/2015/08/13466303.md ```text Signed-off-by: Jyri Sarha --- drivers/video/fbdev/omap2/dss/dss-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/dss/dss-of.c b/drivers/video/fbdev/omap2/dss/dss-of.c index 928ee63..ab6ef16 100644 --- a/drivers/video/fbdev/omap2/dss/dss-of.c +++ b/drivers/video/fbdev/omap2/dss/dss-of.c @@ -60,6 +60,7 @@ omapdss_of_get_next_port(const struct device_node *parent, } prev = port; } while (of_node_cmp(port->name, "port") != 0); + of_node_put(ports); } return port; -- 1.9.1 ``` ## Re: \[PATCH 1/2\] OMAPDSS: dss-of: Fix node refcount leak in omapdss\_of\_get\_next\_port() - From: Tomi Valkeinen \ - Date: 2015-08-07 10:38:23 - Message: https://ratatoskr.run/linux-fbdev/2015/08/13466304.md ```text On 06/08/15 21:41, Jyri Sarha wrote: > Signed-off-by: Jyri Sarha Please always fill in the patch description. In simplest cases it may be the same as in the subject. > --- > drivers/video/fbdev/omap2/dss/dss-of.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/omap2/dss/dss-of.c b/drivers/video/fbdev/omap2/dss/dss-of.c > index 928ee63..ab6ef16 100644 > --- a/drivers/video/fbdev/omap2/dss/dss-of.c > +++ b/drivers/video/fbdev/omap2/dss/dss-of.c > @@ -60,6 +60,7 @@ omapdss_of_get_next_port(const struct device_node *parent, > } > prev = port; > } while (of_node_cmp(port->name, "port") != 0); > + of_node_put(ports); I think a blank line is needed above of_node_put(). Tomi ```