# Re: \[PATCH v2\] backlight: lp8788: Deletion of a check before backlight\_device\_unregister()

- From: SF Markus Elfring \<hidden\>
- Date: 2015-06-28 12:07:54 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2015/06/4524125
- Thread: https://ratatoskr.run/linux-fbdev/2014/11/4380455/t.md

```text
> From: Markus Elfring <redacted>
> 
> The backlight_device_unregister() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <redacted>
> ---
>  drivers/video/backlight/lp8788_bl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c
> index d6c4f6a..24a055c 100644
> --- a/drivers/video/backlight/lp8788_bl.c
> +++ b/drivers/video/backlight/lp8788_bl.c
> @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl)
>  {
>  	struct backlight_device *bl_dev = bl->bl_dev;
>  
> -	if (bl_dev)
> -		backlight_device_unregister(bl_dev);
> +	backlight_device_unregister(bl_dev);
>  }
>  
>  static ssize_t lp8788_get_bl_ctl_mode(struct device *dev,
> 

Would you like to integrate this update suggestion
into another source code repository?

Regards,
Markus
```