This patch set adds a new API to get phy by index when multiple
phys are present. This patch is based on discussion with Arnd Bergmann
about dt bindings for multiple phys.
History:
v1:
- Removed null pointers on Dmitry's suggestion
- Improved documentation in commit messages
- Exported new phy api
v2:
- EHCI and OHCI platform Kconfigs select Generic Phy
to fix build errors in certain configs.
v3:
- Made GENERIC_PHY an invisible option so
that other configs can select it
- Added stubs for devm_of_phy_get_by_index
- Reformated code
Arun Ramamurthy (4):
phy: phy-core: Make GENERIC_PHY an invisible option
phy: core: Add devm_of_phy_get_by_index to phy-core
usb: ehci-platform: Use devm_of_phy_get_by_index
usb: ohci-platform: Use devm_of_phy_get_by_index
Documentation/phy.txt | 7 +++-
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 +-
drivers/phy/phy-core.c | 32 ++++++++++++++
drivers/usb/host/Kconfig | 4 +-
drivers/usb/host/ehci-platform.c | 69 +++++++++++--------------------
drivers/usb/host/ohci-platform.c | 69 +++++++++++--------------------
drivers/video/fbdev/exynos/Kconfig | 2 +-
include/linux/phy/phy.h | 8 ++++
10 files changed, 100 insertions(+), 98 deletions(-)
--
2.3.4
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHYselectUSB_EHCI_HCD_PLATFORMhelpEnablesupportfortheon-chipEHCIcontrollerfoundon
@@ -409,7 +409,7 @@ config USB_OHCI_HCD_SPEARconfigUSB_OHCI_HCD_STItristate"Support for ST STiHxxx on-chip OHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHYselectUSB_OHCI_HCD_PLATFORMhelpEnablesupportfortheon-chipOHCIcontrollerfoundon
Getting phys by index instead of phy names so that we do
not have to create a naming scheme when multiple phys
are present
Signed-off-by: Arun Ramamurthy <redacted>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
---
drivers/usb/host/ehci-platform.c | 69 ++++++++++++++--------------------------
1 file changed, 24 insertions(+), 45 deletions(-)
Getting phys by index instead of phy names so that we do
not have to create a naming scheme when multiple phys are present
Signed-off-by: Arun Ramamurthy <redacted>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
---
drivers/usb/host/ohci-platform.c | 69 ++++++++++++++--------------------------
1 file changed, 24 insertions(+), 45 deletions(-)
Some generic drivers, such as ehci, may use multiple phys and for such
drivers referencing phy(s) by name(s) does not make sense. Instead of
inventing new naming schemes and using custom code to iterate through them,
such drivers are better of using nameless phy bindings and using this newly
introduced API to iterate through them.
Signed-off-by: Arun Ramamurthy <redacted>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
---
Documentation/phy.txt | 7 ++++++-
drivers/phy/phy-core.c | 32 ++++++++++++++++++++++++++++++++
include/linux/phy/phy.h | 8 ++++++++
3 files changed, 46 insertions(+), 1 deletion(-)
@@ -76,6 +76,8 @@ struct phy *phy_get(struct device *dev, const char *string); struct phy *phy_optional_get(struct device *dev, const char *string); struct phy *devm_phy_get(struct device *dev, const char *string); struct phy *devm_phy_optional_get(struct device *dev, const char *string);+struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,+ int index); phy_get, phy_optional_get, devm_phy_get and devm_phy_optional_get can be used to get the PHY. In the case of dt boot, the string arguments
@@ -86,7 +88,10 @@ successful PHY get. On driver detach, release function is invoked on the the devres data and devres data is freed. phy_optional_get and devm_phy_optional_get should be used when the phy is optional. These two functions will never return -ENODEV, but instead returns NULL when-the phy cannot be found.+the phy cannot be found.Some generic drivers, such as ehci, may use multiple+phys and for such drivers referencing phy(s) by name(s) does not make sense. In+this case, devm_of_phy_get_by_index can be used to get a phy reference based on+the index. It should be noted that NULL is a valid phy reference. All phy consumer calls on the NULL phy become NOPs. That is the release calls,
From: Hans de Goede <hidden> Date: 2015-04-23 07:43:55
Hi,
On 23-04-15 01:04, Arun Ramamurthy wrote:
This patch set adds a new API to get phy by index when multiple
phys are present. This patch is based on discussion with Arnd Bergmann
about dt bindings for multiple phys.
History:
v1:
- Removed null pointers on Dmitry's suggestion
- Improved documentation in commit messages
- Exported new phy api
v2:
- EHCI and OHCI platform Kconfigs select Generic Phy
to fix build errors in certain configs.
v3:
- Made GENERIC_PHY an invisible option so
that other configs can select it
- Added stubs for devm_of_phy_get_by_index
- Reformated code
Arun Ramamurthy (4):
phy: phy-core: Make GENERIC_PHY an invisible option
phy: core: Add devm_of_phy_get_by_index to phy-core
usb: ehci-platform: Use devm_of_phy_get_by_index
usb: ohci-platform: Use devm_of_phy_get_by_index
Documentation/phy.txt | 7 +++-
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 +-
drivers/phy/phy-core.c | 32 ++++++++++++++
drivers/usb/host/Kconfig | 4 +-
drivers/usb/host/ehci-platform.c | 69 +++++++++++--------------------
drivers/usb/host/ohci-platform.c | 69 +++++++++++--------------------
drivers/video/fbdev/exynos/Kconfig | 2 +-
include/linux/phy/phy.h | 8 ++++
10 files changed, 100 insertions(+), 98 deletions(-)
Patch set looks good to me:
Acked-by: Hans de Goede <redacted>
Regards,
Hans
From: Alan Stern <stern@rowland.harvard.edu> Date: 2015-04-23 14:31:50
On Wed, 22 Apr 2015, Arun Ramamurthy wrote:
This patch set adds a new API to get phy by index when multiple
phys are present. This patch is based on discussion with Arnd Bergmann
about dt bindings for multiple phys.
History:
v1:
- Removed null pointers on Dmitry's suggestion
- Improved documentation in commit messages
- Exported new phy api
v2:
- EHCI and OHCI platform Kconfigs select Generic Phy
to fix build errors in certain configs.
v3:
- Made GENERIC_PHY an invisible option so
that other configs can select it
- Added stubs for devm_of_phy_get_by_index
- Reformated code
Arun Ramamurthy (4):
phy: phy-core: Make GENERIC_PHY an invisible option
phy: core: Add devm_of_phy_get_by_index to phy-core
usb: ehci-platform: Use devm_of_phy_get_by_index
usb: ohci-platform: Use devm_of_phy_get_by_index
For patches 3 and 4:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
From: Kishon Vijay Abraham I <hidden> Date: 2015-05-11 13:46:21
Hi,
On Thursday 23 April 2015 08:01 PM, Alan Stern wrote:
On Wed, 22 Apr 2015, Arun Ramamurthy wrote:
quoted
This patch set adds a new API to get phy by index when multiple
phys are present. This patch is based on discussion with Arnd Bergmann
about dt bindings for multiple phys.
History:
v1:
- Removed null pointers on Dmitry's suggestion
- Improved documentation in commit messages
- Exported new phy api
v2:
- EHCI and OHCI platform Kconfigs select Generic Phy
to fix build errors in certain configs.
v3:
- Made GENERIC_PHY an invisible option so
that other configs can select it
- Added stubs for devm_of_phy_get_by_index
- Reformated code
Arun Ramamurthy (4):
phy: phy-core: Make GENERIC_PHY an invisible option
phy: core: Add devm_of_phy_get_by_index to phy-core
usb: ehci-platform: Use devm_of_phy_get_by_index
usb: ohci-platform: Use devm_of_phy_get_by_index
For patches 3 and 4:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
From: Kishon Vijay Abraham I <hidden> Date: 2015-05-11 15:11:20
Hi,
On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote:
quoted hunk
Some generic drivers, such as ehci, may use multiple phys and for such
drivers referencing phy(s) by name(s) does not make sense. Instead of
inventing new naming schemes and using custom code to iterate through them,
such drivers are better of using nameless phy bindings and using this newly
introduced API to iterate through them.
Signed-off-by: Arun Ramamurthy <redacted>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
---
Documentation/phy.txt | 7 ++++++-
drivers/phy/phy-core.c | 32 ++++++++++++++++++++++++++++++++
include/linux/phy/phy.h | 8 ++++++++
3 files changed, 46 insertions(+), 1 deletion(-)
@@ -76,6 +76,8 @@ struct phy *phy_get(struct device *dev, const char *string); struct phy *phy_optional_get(struct device *dev, const char *string); struct phy *devm_phy_get(struct device *dev, const char *string); struct phy *devm_phy_optional_get(struct device *dev, const char *string);+struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,+ int index); phy_get, phy_optional_get, devm_phy_get and devm_phy_optional_get can be used to get the PHY. In the case of dt boot, the string arguments
@@ -86,7 +88,10 @@ successful PHY get. On driver detach, release function is invoked on the the devres data and devres data is freed. phy_optional_get and devm_phy_optional_get should be used when the phy is optional. These two functions will never return -ENODEV, but instead returns NULL when-the phy cannot be found.+the phy cannot be found.Some generic drivers, such as ehci, may use multiple+phys and for such drivers referencing phy(s) by name(s) does not make sense. In+this case, devm_of_phy_get_by_index can be used to get a phy reference based on+the index. It should be noted that NULL is a valid phy reference. All phy consumer calls on the NULL phy become NOPs. That is the release calls,
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
For media part:
Acked-by: Mauro Carvalho Chehab [off-list ref]
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHYselectUSB_EHCI_HCD_PLATFORMhelpEnablesupportfortheon-chipEHCIcontrollerfoundon
@@ -409,7 +409,7 @@ config USB_OHCI_HCD_SPEARconfigUSB_OHCI_HCD_STItristate"Support for ST STiHxxx on-chip OHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHYselectUSB_OHCI_HCD_PLATFORMhelpEnablesupportfortheon-chipOHCIcontrollerfoundon
From: Felipe Balbi <hidden> Date: 2015-05-15 00:55:06
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted hunk
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
--
balbi
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was
an explicit dependency, I changed it to "depends on" and in other cases
I changed it to "selects". Thanks
From: Felipe Balbi <hidden> Date: 2015-05-26 14:22:48
HI,
On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote:
On 15-05-14 05:52 PM, Felipe Balbi wrote:
quoted
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was an
explicit dependency, I changed it to "depends on" and in other cases I
changed it to "selects". Thanks
Since GENERIC_PHY is visible from Kconfig, it would be much nicer to
avoid select altogether.
--
balbi
HI,
On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote:
quoted
On 15-05-14 05:52 PM, Felipe Balbi wrote:
quoted
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was an
explicit dependency, I changed it to "depends on" and in other cases I
changed it to "selects". Thanks
Since GENERIC_PHY is visible from Kconfig, it would be much nicer to
avoid select altogether.
Felipe, after discussion with the maintainers, I have made GENERIC_PHY
an invisible option as part of this change. Thanks
From: Felipe Balbi <hidden> Date: 2015-05-26 18:43:00
On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote:
Hi
On 15-05-26 07:19 AM, Felipe Balbi wrote:
quoted
HI,
On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote:
quoted
On 15-05-14 05:52 PM, Felipe Balbi wrote:
quoted
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was an
explicit dependency, I changed it to "depends on" and in other cases I
changed it to "selects". Thanks
Since GENERIC_PHY is visible from Kconfig, it would be much nicer to
avoid select altogether.
Felipe, after discussion with the maintainers, I have made GENERIC_PHY an
invisible option as part of this change. Thanks
Then, if the option is invisible, how can you "depend" on it ? It can
never be selected by poking around in Kconfig. IMO, it's
counterintuitive that you need to enable a PHY driver before you can see
your EHCI/OHCI/whatever controller listed in Kconfig.
--
balbi
From: Kishon Vijay Abraham I <hidden> Date: 2015-05-29 11:36:05
Hi Felipe,
On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote:
On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote:
quoted
Hi
On 15-05-26 07:19 AM, Felipe Balbi wrote:
quoted
HI,
On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote:
quoted
On 15-05-14 05:52 PM, Felipe Balbi wrote:
quoted
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was an
explicit dependency, I changed it to "depends on" and in other cases I
changed it to "selects". Thanks
Since GENERIC_PHY is visible from Kconfig, it would be much nicer to
avoid select altogether.
Felipe, after discussion with the maintainers, I have made GENERIC_PHY an
invisible option as part of this change. Thanks
Then, if the option is invisible, how can you "depend" on it ? It can
never be selected by poking around in Kconfig. IMO, it's
counterintuitive that you need to enable a PHY driver before you can see
your EHCI/OHCI/whatever controller listed in Kconfig.
If the controller requires PHY for it to be functional, it is okay to make the
controller depend on PHY IMHO. We want to try and minimize the usage of
'select' wherever possible or else 'select' is the most intuitive way. The
other option is just to leave the 'depends on' and let the user select PHY.
Thanks
Kishon
From: Kishon Vijay Abraham I <hidden> Date: 2015-05-29 12:38:44
Tejun, Maxime, Sylwester, Kyungmin
On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote:
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHYselectUSB_EHCI_HCD_PLATFORMhelpEnablesupportfortheon-chipEHCIcontrollerfoundon
@@ -409,7 +409,7 @@ config USB_OHCI_HCD_SPEARconfigUSB_OHCI_HCD_STItristate"Support for ST STiHxxx on-chip OHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHYselectUSB_OHCI_HCD_PLATFORMhelpEnablesupportfortheon-chipOHCIcontrollerfoundon
From: Maxime Coquelin <hidden> Date: 2015-05-29 13:01:31
Hi Kishon, Arun,
On 05/29/2015 02:37 PM, Kishon Vijay Abraham I wrote:
Tejun, Maxime, Sylwester, Kyungmin
On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since
select
is only recommended when the config is not visible, GENERIC_PHY is
changed
an invisible option. To maintain consistency, all phy providers are
changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when
the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
Need your ACK for this patch.
For the STi part, you can add my:
Acked-by: Maxime Coquelin <redacted>
Regards,
Maxime
On Fri, May 29, 2015 at 06:07:18PM +0530, Kishon Vijay Abraham I wrote:
Tejun, Maxime, Sylwester, Kyungmin
On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
Need your ACK for this patch.
For ATA part,
Acked-by: Tejun Heo [off-list ref]
Thanks.
--
tejun
Tejun, Maxime, Sylwester, Kyungmin
On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
Need your ACK for this patch.
For
drivers/media/platform/exynos4-is/Kconfig
drivers/video/fbdev/exynos/Kconfig
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
--
Thanks,
Sylwester
From: Felipe Balbi <hidden> Date: 2015-05-29 15:07:34
Hi,
On Fri, May 29, 2015 at 05:04:38PM +0530, Kishon Vijay Abraham I wrote:
Hi Felipe,
On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote:
quoted
On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote:
quoted
Hi
On 15-05-26 07:19 AM, Felipe Balbi wrote:
quoted
HI,
On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote:
quoted
On 15-05-14 05:52 PM, Felipe Balbi wrote:
quoted
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was an
explicit dependency, I changed it to "depends on" and in other cases I
changed it to "selects". Thanks
Since GENERIC_PHY is visible from Kconfig, it would be much nicer to
avoid select altogether.
Felipe, after discussion with the maintainers, I have made GENERIC_PHY an
invisible option as part of this change. Thanks
Then, if the option is invisible, how can you "depend" on it ? It can
never be selected by poking around in Kconfig. IMO, it's
counterintuitive that you need to enable a PHY driver before you can see
your EHCI/OHCI/whatever controller listed in Kconfig.
If the controller requires PHY for it to be functional, it is okay to make
the controller depend on PHY IMHO. We want to try and minimize the usage of
'select' wherever possible or else 'select' is the most intuitive way. The
other option is just to leave the 'depends on' and let the user select PHY.
How can you 'depend' on something that the user can't select by
navigating through Kconfig ?
--
balbi
From: Kishon Vijay Abraham I <hidden> Date: 2015-06-01 12:54:08
Hi,
On Friday 29 May 2015 08:34 PM, Felipe Balbi wrote:
Hi,
On Fri, May 29, 2015 at 05:04:38PM +0530, Kishon Vijay Abraham I wrote:
quoted
Hi Felipe,
On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote:
quoted
On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote:
quoted
Hi
On 15-05-26 07:19 AM, Felipe Balbi wrote:
quoted
HI,
On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote:
quoted
On 15-05-14 05:52 PM, Felipe Balbi wrote:
quoted
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was an
explicit dependency, I changed it to "depends on" and in other cases I
changed it to "selects". Thanks
Since GENERIC_PHY is visible from Kconfig, it would be much nicer to
avoid select altogether.
Felipe, after discussion with the maintainers, I have made GENERIC_PHY an
invisible option as part of this change. Thanks
Then, if the option is invisible, how can you "depend" on it ? It can
never be selected by poking around in Kconfig. IMO, it's
counterintuitive that you need to enable a PHY driver before you can see
your EHCI/OHCI/whatever controller listed in Kconfig.
If the controller requires PHY for it to be functional, it is okay to make
the controller depend on PHY IMHO. We want to try and minimize the usage of
'select' wherever possible or else 'select' is the most intuitive way. The
other option is just to leave the 'depends on' and let the user select PHY.
How can you 'depend' on something that the user can't select by
navigating through Kconfig ?
hmm... Actually it's selected when the user selects the PHY driver. Maybe we
should directly depend on the PHY driver instead of Generic PHY?
Thanks
Kishon
From: Felipe Balbi <hidden> Date: 2015-06-01 18:42:20
On Mon, Jun 01, 2015 at 06:22:41PM +0530, Kishon Vijay Abraham I wrote:
Hi,
On Friday 29 May 2015 08:34 PM, Felipe Balbi wrote:
quoted
Hi,
On Fri, May 29, 2015 at 05:04:38PM +0530, Kishon Vijay Abraham I wrote:
quoted
Hi Felipe,
On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote:
quoted
On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote:
quoted
Hi
On 15-05-26 07:19 AM, Felipe Balbi wrote:
quoted
HI,
On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote:
quoted
On 15-05-14 05:52 PM, Felipe Balbi wrote:
quoted
Hi,
On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote:
quoted
Most of the phy providers use "select" to enable GENERIC_PHY. Since select
is only recommended when the config is not visible, GENERIC_PHY is changed
an invisible option. To maintain consistency, all phy providers are changed
to "select" GENERIC_PHY and all non-phy drivers use "depends on" when the
phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic
dependency, so it is left as "select".
Signed-off-by: Arun Ramamurthy <redacted>
---
drivers/ata/Kconfig | 1 -
drivers/media/platform/exynos4-is/Kconfig | 2 +-
drivers/phy/Kconfig | 4 ++--
drivers/usb/host/Kconfig | 4 ++--
drivers/video/fbdev/exynos/Kconfig | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEARconfigUSB_EHCI_HCD_STItristate"Support for ST STiHxxx on-chip EHCI USB controller"depends onARCH_STI&&OF-selectGENERIC_PHY+depends onGENERIC_PHY
while others you changed from select to depends.
NAK.
Felipe, I dont understand your concern, could you please explain it more
detail? The logic behind the changes is that in cases where there was an
explicit dependency, I changed it to "depends on" and in other cases I
changed it to "selects". Thanks
Since GENERIC_PHY is visible from Kconfig, it would be much nicer to
avoid select altogether.
Felipe, after discussion with the maintainers, I have made GENERIC_PHY an
invisible option as part of this change. Thanks
Then, if the option is invisible, how can you "depend" on it ? It can
never be selected by poking around in Kconfig. IMO, it's
counterintuitive that you need to enable a PHY driver before you can see
your EHCI/OHCI/whatever controller listed in Kconfig.
If the controller requires PHY for it to be functional, it is okay to make
the controller depend on PHY IMHO. We want to try and minimize the usage of
'select' wherever possible or else 'select' is the most intuitive way. The
other option is just to leave the 'depends on' and let the user select PHY.
How can you 'depend' on something that the user can't select by
navigating through Kconfig ?
hmm... Actually it's selected when the user selects the PHY driver.
that's my point, don't you think it's a little counter-intuitive ?
Maybe we should directly depend on the PHY driver instead of Generic
PHY?
maybe... But then what do you do when you have different boards using
different PHYs ?
--
balbi