# Re: \[PATCH v1 04/47\] pci: add pci\_ioremap\_wc\_bar()

- From: Andy Lutomirski \<luto@amacapital.net\>
- Date: 2015-03-20 23:50:59 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2015/03/4456161
- Thread: https://ratatoskr.run/linux-fbdev/2015/03/4456096/t.md

```text
On Fri, Mar 20, 2015 at 4:17 PM, Luis R. Rodriguez
[ref] wrote:
> From: "Luis R. Rodriguez" <redacted>
>
> This lets drivers take advanate of PAT when available. This
> should help with the transition of converting video drivers over
> to ioremap_wc() to help with the goal of eventually using
> _PAGE_CACHE_UC over _PAGE_CACHE_UC_MINUS on x86 on
> ioremap_nocache() (de33c442e)
>
> Cc: Suresh Siddha <redacted>
> Cc: Venkatesh Pallipadi <redacted>
> Cc: Ingo Molnar <redacted>
> Cc: Thomas Gleixner <redacted>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Daniel Vetter <redacted>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Antonino Daplas <adaplas@gmail.com>
> Cc: Jean-Christophe Plagniol-Villard <redacted>
> Cc: Tomi Valkeinen <redacted>
> Cc: <redacted>
> Cc: <redacted>
> Signed-off-by: Luis R. Rodriguez <redacted>
> ---
>  drivers/pci/pci.c   | 14 ++++++++++++++
>  include/linux/pci.h |  1 +
>  2 files changed, 15 insertions(+)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 81f06e8..6afd507 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -137,6 +137,20 @@ void __iomem *pci_ioremap_bar(struct pci_dev *pdev, int bar)
>                                      pci_resource_len(pdev, bar));
>  }
>  EXPORT_SYMBOL_GPL(pci_ioremap_bar);
> +
> +void __iomem *pci_ioremap_wc_bar(struct pci_dev *pdev, int bar)
> +{
> +       /*
> +        * Make sure the BAR is actually a memory resource, not an IO resource
> +        */
> +       if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM)) {
> +               WARN_ON(1);
> +               return NULL;
> +       }

if (WARN_ON(...))?

--Andy
```
