# Re: \[PATCH\] staging/sm75fb: Declare static functions as such

- From: Lorenzo Stoakes \<hidden\>
- Date: 2015-03-16 19:03:35 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2015/03/4452253
- Thread: https://ratatoskr.run/linux-fbdev/2015/03/4451509/t.md

```text
On 16 March 2015 at 10:51, Ricardo Ribalda Delgado
[ref] wrote:
> This patch fixes this sparse warning

Hi Ricardo,

I currently have a patch series awaiting the final ok which includes
fixes for these warnings
(http://lkml.iu.edu/hypermail/linux/kernel/1503.1/02535.html),
apologies but assuming there isn't something hideously wrong with my
series I suspect they supersedes this patch :(

It's really easy to accidentally submit a patch that has already been
covered elsewhere; I, as a rather new kernel contributor, always find
I have to search quite a bit to be *sure* that it's not been covered
already.

Additionally, your subject line is 'staging/sm75fb: Declare static
functions as such' which ought to be 'staging: sm750fb: Declare static
functions as such' - there's a typo in the device name and I think the
convention is always to use colons in subject lines.

Best,

-- 
Lorenzo Stoakes
https:/ljs.io
```