[PATCH] staging: sm750fb: braces, indents, spaces fix

Subsystems: staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest

STALE4168d

2 messages, 2 authors, 2015-03-13 · open the first message on its own page

[PATCH] staging: sm750fb: braces, indents, spaces fix

From: Ragavendra BN <hidden>
Date: 2015-03-13 03:43:46

Signed-off-by: Ragavendra BN <redacted>

This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the code give no
warnings by the checkpath.pl script check.

---
 drivers/staging/sm750fb/ddk750_chip.c |   22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
 	physicalID = devId750;//either 0x718 or 0x750
 	physicalRev = revId750;
 
-    if (physicalID = 0x718)
-    {
-        chip = SM718;
-    }
-    else if (physicalID = 0x750)
-    {
-        chip = SM750;
+	if (physicalID = 0x718) {
+		chip = SM718;
+	} else if (physicalID = 0x750) {
+		chip = SM750;
 		/* SM750 and SM750LE are different in their revision ID only. */
-		if (physicalRev = SM750LE_REVISION_ID){
+		if (physicalRev = SM750LE_REVISION_ID)
 			chip = SM750LE;
-		}
-    }
-    else
-    {
-        chip = SM_UNKNOWN;
-    }
+	} else {
+		chip = SM_UNKNOWN;
+	}
 
 	return chip;
 }
-- 
1.7.10.4

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-03-13 04:58:58

On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote:
Signed-off-by: Ragavendra BN <redacted>

This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the code give no
warnings by the checkpath.pl script check.
Signed-off-by line should come here before the ---
---
not at the top like you are giving.
Greg has told you once, I am telling now for the second time.

regards
sudip
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help