[PATCH] video: fbdev: sh_mobile_lcdcfb: Fix ROP3 sysfs attribute parsing

The ROP3 attribute is expressed as an integer in the 0-255 range. Remove
the wrong conversion to boolean when parsing it.

Reported-by: Dan Carpenter <redacted>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
index d3013cd9f976..23421ec1c4e4 100644
--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
+++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c

@@ -1461,7 +1461,7 @@ overlay_rop3_store(struct device *dev, struct device_attribute *attr,
 	unsigned int rop3;
 	char *endp;
 
-	rop3 = !!simple_strtoul(buf, &endp, 10);
+	rop3 = simple_strtoul(buf, &endp, 10);
 	if (isspace(*endp))
 		endp++;
 

-- 
Regards,

Laurent Pinchart

On Sat, Mar 14, 2015 at 4:38 PM, Laurent Pinchart
[off-list ref] wrote:

The ROP3 attribute is expressed as an integer in the 0-255 range. Remove
the wrong conversion to boolean when parsing it.

Reported-by: Dan Carpenter <redacted>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Hi Tomi,

Could you please pick this patch up for v4.1 ? I can send a pull request if it 
makes your life easier.

On Sunday 15 March 2015 10:32:11 Geert Uytterhoeven wrote:

On Sat, Mar 14, 2015 at 4:38 PM, Laurent Pinchart wrote:

quoted

The ROP3 attribute is expressed as an integer in the 0-255 range. Remove
the wrong conversion to boolean when parsing it.

Reported-by: Dan Carpenter <redacted>
Signed-off-by: Laurent Pinchart
[off-list ref]

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

-- 
Regards,

Laurent Pinchart

On 18/03/15 00:27, Laurent Pinchart wrote:

Hi Tomi,

Could you please pick this patch up for v4.1 ? I can send a pull request if it 
makes your life easier.

On Sunday 15 March 2015 10:32:11 Geert Uytterhoeven wrote:

quoted

On Sat, Mar 14, 2015 at 4:38 PM, Laurent Pinchart wrote:

quoted

The ROP3 attribute is expressed as an integer in the 0-255 range. Remove
the wrong conversion to boolean when parsing it.

Reported-by: Dan Carpenter <redacted>
Signed-off-by: Laurent Pinchart
[off-list ref]

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, queued for 4.1.

 Tomi