[PATCH 10/13] staging: sm750: blank line after declaration

Subsystems: staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest

STALE4157d

2 messages, 2 authors, 2015-03-23 · open the first message on its own page

[PATCH 10/13] staging: sm750: blank line after declaration

From: Michel von Czettritz <hidden>
Date: 2015-03-22 23:14:17

This patch fixes "WARNING: Missing a blank line after declaration"
checkpatch.pl warnings.

Signed-off-by: Michel von Czettritz <redacted>
---
 drivers/staging/sm750fb/sm750.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 90dc801..870bf6f 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -61,6 +61,7 @@ static char *g_option = NULL;
 static inline void myspin_lock(spinlock_t *sl)
 {
 	struct lynx_share *share;
+	
 	share = container_of(sl, struct lynx_share, slock);
 	if (share->dual)
 		spin_lock(sl);
@@ -69,6 +70,7 @@ static inline void myspin_lock(spinlock_t *sl)
 static inline void myspin_unlock(spinlock_t *sl)
 {
 	struct lynx_share *share;
+	
 	share = container_of(sl, struct lynx_share, slock);
 	if (share->dual)
 		spin_unlock(sl);
@@ -172,6 +174,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)
 	if (fbcursor->set & FB_CUR_SETCMAP) {
 		/* get the 16bit color of kernel means */
 		u16 fg, bg;
+		
 		fg = ((info->cmap.red[fbcursor->image.fg_color] & 0xf800))|
 			((info->cmap.green[fbcursor->image.fg_color] & 0xfc00) >> 5)|
 			((info->cmap.blue[fbcursor->image.fg_color] & 0xf800) >> 11);
@@ -650,6 +653,7 @@ static int lynxfb_ops_setcolreg(unsigned regno, unsigned red,
 
 	if (info->fix.visual = FB_VISUAL_TRUECOLOR && regno < 256) {
 		u32 val;
+		
 		if (var->bits_per_pixel = 16 ||
 				var->bits_per_pixel = 32 ||
 				var->bits_per_pixel = 24) {
@@ -1187,6 +1191,7 @@ ALLOC_FB:
 	} else {
 		struct lynxfb_par *par;
 		int errno;
+		
 		pr_info("framebuffer #%d alloc okay\n", fbidx);
 		share->fbinfo[fbidx] = info[fbidx];
 		par = info[fbidx]->par;
-- 
2.3.3

Re: [PATCH 10/13] staging: sm750: blank line after declaration

From: Dan Carpenter <hidden>
Date: 2015-03-23 11:26:23

On Mon, Mar 23, 2015 at 12:14:17AM +0100, Michel von Czettritz wrote:
quoted hunk
This patch fixes "WARNING: Missing a blank line after declaration"
checkpatch.pl warnings.

Signed-off-by: Michel von Czettritz <redacted>
---
 drivers/staging/sm750fb/sm750.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 90dc801..870bf6f 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -61,6 +61,7 @@ static char *g_option = NULL;
 static inline void myspin_lock(spinlock_t *sl)
 {
 	struct lynx_share *share;
+	
These introduces new checkpatch warnings.  Use checkpatch.pl on your own
patches.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help