# \[PATCH v10 0/6\] Add Skyworks SKY81452 device drivers - Subsystems: FRAMEBUFFER LAYER, BACKLIGHT CLASS/SUBSYSTEM, I2C SUBSYSTEM HOST DRIVERS, MULTIFUNCTION DEVICES (MFD), OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, THE REST - Maintainers: Helge Deller, Lee Jones, Daniel Thompson, Jingoo Han, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds - Series: 6 patches touching 12 files - Status: SUPERSEDED (Superseded by v11 posted 2015-02-05) - Superseded by v11 (posted 2015-02-05). - Revision v10 (8 revisions archived). - List: linux-fbdev - 3 messages, 1 author - Page: https://ratatoskr.run/linux-fbdev/2015/02/4425887/t ## \[PATCH v10 0/6\] Add Skyworks SKY81452 device drivers - From: \ - Date: 2015-02-05 06:29:57 - Message: https://ratatoskr.run/linux-fbdev/2015/02/4425887.md ```text From: Gyungoh Yoo This patch set includes regulator and backlight driver for SKY81452. Also it includes documents for device tree and module. sky81452-regulator was already applied. So this series doesn't include it. v10: Removed trivial get_brightness implementations for sky81452-backlight v9: Removed the change to remove MODULE_VERSION() for sky81452-regulator v8: Renamed property names for backlight with vendor prefix Modified gpio-enable property to generic property for GPIO Made up the example for backlight DT Changed the DT parsing of regulator using regulator_node and of_match v7: Modified licensing text to GPLv2 Splitted Kconfig renaming from DT patch v6: Added new line character at the end of line of dev_err() v5: Changed DT for regulator : 'lout' node should be defined under 'regulator' Removed compatible string from sky81452-regulator driver Modified sky81452-regulator to return EINVAL when of_node is NULL Move sky81452-backlight.h to include/linux/platform_data v4: Removed MODULE_VERSION() Modified license to GPLv2 Removed calling to backlight_device_unregister() in sky81452-backlight v3: Cleaned-up DBG messages Cleaned-up DT Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight' Assigned mfd_cell.of_compatible for binding device node Modified error messages Modified sky81452-regulator to return ENODATA when of_node is NULL v2: Split the patches for each sub-system Added 'reg' attribute for I2C address in device tree documents Added 'compatible' attribute in child drivers Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452 Added message for exception or errors. Added vendor prefix for Skyworks Solutions, Inc. Add SKY81452 to the Trivial Devices list Gyungoh Yoo (6): mfd: Add support for Skyworks SKY81452 driver backlight: Add support Skyworks SKY81452 backlight driver devicetree: mfd: Add new SKY81452 mfd binding devicetree: backlight: Add new SKY81452 backlight binding devicetree: Add vendor prefix for Skyworks Solutions, Inc. devicetree: i2c: Add SKY81452 to the Trivial Devices list .../devicetree/bindings/i2c/trivial-devices.txt | 1 + Documentation/devicetree/bindings/mfd/sky81452.txt | 36 +++ .../devicetree/bindings/vendor-prefixes.txt | 1 + .../video/backlight/sky81452-backlight.txt | 29 ++ drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile | 1 + drivers/mfd/sky81452.c | 108 +++++++ drivers/video/backlight/Kconfig | 10 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/sky81452-backlight.c | 334 +++++++++++++++++++++ include/linux/mfd/sky81452.h | 31 ++ include/linux/platform_data/sky81452-backlight.h | 46 +++ 12 files changed, 610 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt create mode 100644 drivers/mfd/sky81452.c create mode 100644 drivers/video/backlight/sky81452-backlight.c create mode 100644 include/linux/mfd/sky81452.h create mode 100644 include/linux/platform_data/sky81452-backlight.h -- 1.9.1 ``` ## \[PATCH v10 1/6\] mfd: Add support for Skyworks SKY81452 driver - From: \ - Date: 2015-02-05 06:30:06 - Message: https://ratatoskr.run/linux-fbdev/2015/02/4425888.md ```text From: Gyungoh Yoo Signed-off-by: Gyungoh Yoo Acked-by: Lee Jones --- Changes v10: Nothing Changes v9: Nothing Changes v8: Nothing Changes v7: Modified licensing text to GPLv2 Changes v6: Added new line character at the end of line of dev_err() Changes v5: Move sky81452-backlight.h to include/linux/platform_data Changes v4: Removed MODULE_VERSION() Modified license to GPLv2 Changes v3: Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight' Assigned mfd_cell.of_compatible for binding device node Modified error messages Changes v2: Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452 Added message for exception or errors drivers/mfd/Kconfig | 12 +++++ drivers/mfd/Makefile | 1 + drivers/mfd/sky81452.c | 108 +++++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/sky81452.h | 31 +++++++++++++ 4 files changed, 152 insertions(+) create mode 100644 drivers/mfd/sky81452.c create mode 100644 include/linux/mfd/sky81452.h diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 1456ea7..a54244c 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -693,6 +693,18 @@ config MFD_SM501_GPIO lines on the SM501. The platform data is used to supply the base number for the first GPIO line to register. +config MFD_SKY81452 + tristate "Skyworks Solutions SKY81452" + select MFD_CORE + select REGMAP_I2C + depends on I2C + help + This is the core driver for the Skyworks SKY81452 backlight and + voltage regulator device. + + This driver can also be built as a module. If so, the module + will be called sky81452. + config MFD_SMSC bool "SMSC ECE1099 series chips" depends on I2C=y diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 8bd54b1..d9683ea 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -174,6 +174,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o obj-$(CONFIG_MFD_HI6421_PMIC) += hi6421-pmic-core.o +obj-$(CONFIG_MFD_SKY81452) += sky81452.o intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c new file mode 100644 index 0000000..b0c9b04 --- /dev/null +++ b/drivers/mfd/sky81452.c @@ -0,0 +1,108 @@ +/* + * sky81452.c SKY81452 MFD driver + * + * Copyright 2014 Skyworks Solutions Inc. + * Author : Gyungoh Yoo + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, see . + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static const struct regmap_config sky81452_config = { + .reg_bits = 8, + .val_bits = 8, +}; + +static int sky81452_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct device *dev = &client->dev; + const struct sky81452_platform_data *pdata = dev_get_platdata(dev); + struct mfd_cell cells[2]; + struct regmap *regmap; + int ret; + + if (!pdata) { + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return -ENOMEM; + } + + regmap = devm_regmap_init_i2c(client, &sky81452_config); + if (IS_ERR(regmap)) { + dev_err(dev, "failed to initialize.err=%ld\n", PTR_ERR(regmap)); + return PTR_ERR(regmap); + } + + i2c_set_clientdata(client, regmap); + + memset(cells, 0, sizeof(cells)); + cells[0].name = "sky81452-backlight"; + cells[0].of_compatible = "skyworks,sky81452-backlight"; + cells[0].platform_data = pdata->bl_pdata; + cells[0].pdata_size = sizeof(*pdata->bl_pdata); + cells[1].name = "sky81452-regulator"; + cells[1].platform_data = pdata->regulator_init_data; + cells[1].pdata_size = sizeof(*pdata->regulator_init_data); + + ret = mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), NULL, 0, NULL); + if (ret) + dev_err(dev, "failed to add child devices. err=%d\n", ret); + + return ret; +} + +static int sky81452_remove(struct i2c_client *client) +{ + mfd_remove_devices(&client->dev); + return 0; +} + +static const struct i2c_device_id sky81452_ids[] = { + { "sky81452" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, sky81452_ids); + +#ifdef CONFIG_OF +static const struct of_device_id sky81452_of_match[] = { + { .compatible = "skyworks,sky81452", }, + { } +}; +MODULE_DEVICE_TABLE(of, sky81452_of_match); +#endif + +static struct i2c_driver sky81452_driver = { + .driver = { + .name = "sky81452", + .of_match_table = of_match_ptr(sky81452_of_match), + }, + .probe = sky81452_probe, + .remove = sky81452_remove, + .id_table = sky81452_ids, +}; + +module_i2c_driver(sky81452_driver); + +MODULE_DESCRIPTION("Skyworks SKY81452 MFD driver"); +MODULE_AUTHOR("Gyungoh Yoo "); +MODULE_LICENSE("GPL v2"); diff --git a/include/linux/mfd/sky81452.h b/include/linux/mfd/sky81452.h new file mode 100644 index 0000000..b0925fa --- /dev/null +++ b/include/linux/mfd/sky81452.h @@ -0,0 +1,31 @@ +/* + * sky81452.h SKY81452 MFD driver + * + * Copyright 2014 Skyworks Solutions Inc. + * Author : Gyungoh Yoo + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, see . + */ + +#ifndef _SKY81452_H +#define _SKY81452_H + +#include +#include + +struct sky81452_platform_data { + struct sky81452_bl_platform_data *bl_pdata; + struct regulator_init_data *regulator_init_data; +}; + +#endif -- 1.9.1 ``` ## Re: \[PATCH v10 0/6\] Add Skyworks SKY81452 device drivers - From: Gyungoh Yoo \ - Date: 2015-02-05 06:34:50 - Message: https://ratatoskr.run/linux-fbdev/2015/02/4425897.md ```text On Thu, Feb 05, 2015 at 03:29:40PM +0900, gyungoh@gmail.com wrote: Please ignore this patch serial v10. Sorry for my mistake > From: Gyungoh Yoo > > This patch set includes regulator and backlight driver for SKY81452. > Also it includes documents for device tree and module. > sky81452-regulator was already applied. So this series doesn't > include it. > > v10: > Removed trivial get_brightness implementations for sky81452-backlight > > v9: > Removed the change to remove MODULE_VERSION() for sky81452-regulator > > v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable property to generic property for GPIO > Made up the example for backlight DT > Changed the DT parsing of regulator using regulator_node and of_match > > v7: > Modified licensing text to GPLv2 > Splitted Kconfig renaming from DT patch > > v6: > Added new line character at the end of line of dev_err() > > v5: > Changed DT for regulator : 'lout' node should be defined under 'regulator' > Removed compatible string from sky81452-regulator driver > Modified sky81452-regulator to return EINVAL when of_node is NULL > Move sky81452-backlight.h to include/linux/platform_data > > v4: > Removed MODULE_VERSION() > Modified license to GPLv2 > Removed calling to backlight_device_unregister() in sky81452-backlight > > v3: > Cleaned-up DBG messages > Cleaned-up DT > Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight' > Assigned mfd_cell.of_compatible for binding device node > Modified error messages > Modified sky81452-regulator to return ENODATA when of_node is NULL > > v2: > Split the patches for each sub-system > Added 'reg' attribute for I2C address in device tree documents > Added 'compatible' attribute in child drivers > Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 > Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452 > Added message for exception or errors. > Added vendor prefix for Skyworks Solutions, Inc. > Add SKY81452 to the Trivial Devices list > > Gyungoh Yoo (6): > mfd: Add support for Skyworks SKY81452 driver > backlight: Add support Skyworks SKY81452 backlight driver > devicetree: mfd: Add new SKY81452 mfd binding > devicetree: backlight: Add new SKY81452 backlight binding > devicetree: Add vendor prefix for Skyworks Solutions, Inc. > devicetree: i2c: Add SKY81452 to the Trivial Devices list > > .../devicetree/bindings/i2c/trivial-devices.txt | 1 + > Documentation/devicetree/bindings/mfd/sky81452.txt | 36 +++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > .../video/backlight/sky81452-backlight.txt | 29 ++ > drivers/mfd/Kconfig | 12 + > drivers/mfd/Makefile | 1 + > drivers/mfd/sky81452.c | 108 +++++++ > drivers/video/backlight/Kconfig | 10 + > drivers/video/backlight/Makefile | 1 + > drivers/video/backlight/sky81452-backlight.c | 334 +++++++++++++++++++++ > include/linux/mfd/sky81452.h | 31 ++ > include/linux/platform_data/sky81452-backlight.h | 46 +++ > 12 files changed, 610 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > create mode 100644 drivers/mfd/sky81452.c > create mode 100644 drivers/video/backlight/sky81452-backlight.c > create mode 100644 include/linux/mfd/sky81452.h > create mode 100644 include/linux/platform_data/sky81452-backlight.h > > -- > 1.9.1 > ```