# \[RFC PATCH\] fbcon: Remove unused vblank cursor code

- Subsystems: FRAMEBUFFER LAYER, CONSOLE SUBSYSTEM, THE REST
- Maintainers: Helge Deller, Greg Kroah-Hartman, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2015/01/4416518/t

## \[RFC PATCH\] fbcon: Remove unused vblank cursor code

- From: Scot Doyle \<hidden\>
- Date: 2015-01-23 22:57:49 
- Message: https://ratatoskr.run/linux-fbdev/2015/01/4416518.md

```text
commit 1fa0b29f3a43 ("fbdev: Kill Atari vblank cursor blinking")

rendered vbl_cursor_cnt and therefore CURSOR_DRAW_DELAY unused in fbcon.c,
so remove them.

Signed-off-by: Scot Doyle <redacted>
---
 drivers/video/console/fbcon.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index ea43724..b972106 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -146,9 +146,6 @@ static const struct consw fb_con;
 
 static int fbcon_set_origin(struct vc_data *);
 
-#define CURSOR_DRAW_DELAY		(1)
-
-static int vbl_cursor_cnt;
 static int fbcon_cursor_noblink;
 
 #define divides(a, b)	((!(a) || (b)%(a)) ? 0 : 1)
@@ -1329,7 +1326,6 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
 
 	ops->cursor(vc, info, mode, y, get_color(vc, info, c, 1),
 		    get_color(vc, info, c, 0));
-	vbl_cursor_cnt = CURSOR_DRAW_DELAY;
 }
 
 static int scrollback_phys_max = 0;
-- 
2.1.4

```

## Re: \[RFC PATCH\] fbcon: Remove unused vblank cursor code

- From: Tomi Valkeinen \<hidden\>
- Date: 2015-01-26 12:11:54 
- Message: https://ratatoskr.run/linux-fbdev/2015/01/4417640.md

```text
On 24/01/15 00:55, Scot Doyle wrote:
> commit 1fa0b29f3a43 ("fbdev: Kill Atari vblank cursor blinking")
> 
> rendered vbl_cursor_cnt and therefore CURSOR_DRAW_DELAY unused in fbcon.c,
> so remove them.
> 
> Signed-off-by: Scot Doyle <redacted>
> ---
>  drivers/video/console/fbcon.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index ea43724..b972106 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -146,9 +146,6 @@ static const struct consw fb_con;
>  
>  static int fbcon_set_origin(struct vc_data *);
>  
> -#define CURSOR_DRAW_DELAY		(1)
> -
> -static int vbl_cursor_cnt;
>  static int fbcon_cursor_noblink;
>  
>  #define divides(a, b)	((!(a) || (b)%(a)) ? 0 : 1)
> @@ -1329,7 +1326,6 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
>  
>  	ops->cursor(vc, info, mode, y, get_color(vc, info, c, 1),
>  		    get_color(vc, info, c, 0));
> -	vbl_cursor_cnt = CURSOR_DRAW_DELAY;
>  }
>  
>  static int scrollback_phys_max = 0;
> 

Thanks, queued for 3.20.

 Tomi


```