# \[PATCH v2 1/2\] drm: Drop superfluous "select VT\_HW\_CONSOLE\_BINDING" - Subsystems: ARM/Rockchip SoC support, DRM DRIVERS, DRM DRIVERS AND MISC GPU PATCHES, DRM DRIVERS FOR EXYNOS, DRM DRIVERS FOR ROCKCHIP, THE REST - Maintainers: Heiko Stuebner, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Inki Dae, Seung-Woo Kim, Kyungmin Park, Sandy Huang, Andy Yan, Linus Torvalds - List: linux-fbdev - 4 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2015/01/4408251/t ## \[PATCH v2 1/2\] drm: Drop superfluous "select VT\_HW\_CONSOLE\_BINDING" - From: Geert Uytterhoeven \ - Date: 2015-01-12 20:10:21 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4408251.md ```text commit 765d5b9c2b72f5b9 ("fbdev: fbcon: select VT_HW_CONSOLE_BINDING") made FRAMEBUFFER_CONSOLE always select VT_HW_CONSOLE_BINDING, but forgot to remove select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE from the individual drivers' sections that already did this before. Remove it, also from new drivers. Signed-off-by: Geert Uytterhoeven --- v2: - Split in two (drm and video) patches, - Fix recently added rockchip. --- drivers/gpu/drm/exynos/Kconfig | 1 - drivers/gpu/drm/rockchip/Kconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 7f9f6f9e9b7e7992..c072999b7e0345c6 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -6,7 +6,6 @@ config DRM_EXYNOS select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE select VIDEOMODE_HELPERS help Choose this option if you have a Samsung SoC EXYNOS chipset. diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig index ca9f085efa922982..8652dad82009e3ce 100644 --- a/drivers/gpu/drm/rockchip/Kconfig +++ b/drivers/gpu/drm/rockchip/Kconfig @@ -7,7 +7,6 @@ config DRM_ROCKCHIP select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE select VIDEOMODE_HELPERS help Choose this option if you have a Rockchip soc chipset. -- 1.9.1 ``` ## \[PATCH v2 2/2\] video: Drop superfluous "select VT\_HW\_CONSOLE\_BINDING" - From: Geert Uytterhoeven \ - Date: 2015-01-12 20:10:19 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4408252.md ```text commit 765d5b9c2b72f5b99722cdfcf4bf8f88c556cf92 ("fbdev: fbcon: select VT_HW_CONSOLE_BINDING") made FRAMEBUFFER_CONSOLE always select VT_HW_CONSOLE_BINDING, but forgot to remove select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE from the individual drivers' sections that already did this before. Signed-off-by: Geert Uytterhoeven --- v2: - Split in two (drm and video) patches. --- drivers/video/fbdev/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 4916c97216f880fc..f2c3fb7d03992ad1 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2151,7 +2151,6 @@ config FB_PS3 select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT select FB_SYS_FOPS - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE ---help--- Include support for the virtual frame buffer in the PS3 platform. -- 1.9.1 ``` ## Re: \[PATCH v2 1/2\] drm: Drop superfluous "select VT\_HW\_CONSOLE\_BINDING" - From: Daniel Vetter \ - Date: 2015-01-12 22:47:51 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4408330.md ```text On Mon, Jan 12, 2015 at 09:10:12PM +0100, Geert Uytterhoeven wrote: > commit 765d5b9c2b72f5b9 ("fbdev: fbcon: select VT_HW_CONSOLE_BINDING") > made FRAMEBUFFER_CONSOLE always select VT_HW_CONSOLE_BINDING, but forgot > to remove > > select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > > from the individual drivers' sections that already did this before. > > Remove it, also from new drivers. > > Signed-off-by: Geert Uytterhoeven Merged into my drm misc branch, thanks. -Daniel > --- > v2: > - Split in two (drm and video) patches, > - Fix recently added rockchip. > --- > drivers/gpu/drm/exynos/Kconfig | 1 - > drivers/gpu/drm/rockchip/Kconfig | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > index 7f9f6f9e9b7e7992..c072999b7e0345c6 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -6,7 +6,6 @@ config DRM_EXYNOS > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > select VIDEOMODE_HELPERS > help > Choose this option if you have a Samsung SoC EXYNOS chipset. > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index ca9f085efa922982..8652dad82009e3ce 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -7,7 +7,6 @@ config DRM_ROCKCHIP > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > select VIDEOMODE_HELPERS > help > Choose this option if you have a Rockchip soc chipset. > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ``` ## Re: \[PATCH v2 2/2\] video: Drop superfluous "select VT\_HW\_CONSOLE\_BINDING" - From: Tomi Valkeinen \ - Date: 2015-01-13 13:19:23 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4408721.md ```text On 12/01/15 22:10, Geert Uytterhoeven wrote: > commit 765d5b9c2b72f5b99722cdfcf4bf8f88c556cf92 ("fbdev: fbcon: select > VT_HW_CONSOLE_BINDING") made FRAMEBUFFER_CONSOLE always select > VT_HW_CONSOLE_BINDING, but forgot to remove > > select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > > from the individual drivers' sections that already did this before. > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Split in two (drm and video) patches. > --- > drivers/video/fbdev/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 4916c97216f880fc..f2c3fb7d03992ad1 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2151,7 +2151,6 @@ config FB_PS3 > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > select FB_SYS_FOPS > - select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > ---help--- > Include support for the virtual frame buffer in the PS3 platform. > > Thanks, queued for 3.20. Tomi ```