# \[PATCH\] fbdev: ssd1307fb: drop unused function ssd1307fb\_write\_data() - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2015/01/4408211/t ## \[PATCH\] fbdev: ssd1307fb: drop unused function ssd1307fb\_write\_data() - From: Lad, Prabhakar \ - Date: 2015-01-12 19:27:54 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4408211.md ```text this patch drops the unused function ssd1307fb_write_data(). Signed-off-by: Lad, Prabhakar --- drivers/video/fbdev/ssd1307fb.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index a7ecaa6..c891f11 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd) return ret; } -static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data) -{ - struct ssd1307fb_array *array; - int ret; - - array = ssd1307fb_alloc_array(1, SSD1307FB_DATA); - if (!array) - return -ENOMEM; - - array->data[0] = data; - - ret = ssd1307fb_write_array(client, array, 1); - kfree(array); - - return ret; -} - static void ssd1307fb_update_display(struct ssd1307fb_par *par) { struct ssd1307fb_array *array; -- 1.9.1 ``` ## Re: \[PATCH\] fbdev: ssd1307fb: drop unused function ssd1307fb\_write\_data() - From: Maxime Ripard \ - Date: 2015-01-13 13:45:05 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4408740.md ```text On Mon, Jan 12, 2015 at 07:21:14PM +0000, Lad, Prabhakar wrote: > this patch drops the unused function ssd1307fb_write_data(). > > Signed-off-by: Lad, Prabhakar Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ``` ## Re: \[PATCH\] fbdev: ssd1307fb: drop unused function ssd1307fb\_write\_data() - From: Tomi Valkeinen \ - Date: 2015-01-15 11:26:58 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4410538.md ```text On 12/01/15 21:21, Lad, Prabhakar wrote: > this patch drops the unused function ssd1307fb_write_data(). > > Signed-off-by: Lad, Prabhakar > --- > drivers/video/fbdev/ssd1307fb.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index a7ecaa6..c891f11 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd) > return ret; > } > > -static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data) > -{ > - struct ssd1307fb_array *array; > - int ret; > - > - array = ssd1307fb_alloc_array(1, SSD1307FB_DATA); > - if (!array) > - return -ENOMEM; > - > - array->data[0] = data; > - > - ret = ssd1307fb_write_array(client, array, 1); > - kfree(array); > - > - return ret; > -} > - > static void ssd1307fb_update_display(struct ssd1307fb_par *par) > { > struct ssd1307fb_array *array; > Thanks, queued for 3.20. Tomi ```