# Re: \[PATCH\]\[RESEND\] static code analysis from cppcheck reports:

- From: Colin Ian King \<hidden\>
- Date: 2015-01-12 18:04:35 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2015/01/4408039
- Thread: https://ratatoskr.run/linux-fbdev/2015/01/4407793/t.md

```text
On 12/01/15 18:02, Geert Uytterhoeven wrote:
> On Mon, Jan 12, 2015 at 4:27 PM, Colin King [ref] wrote:
>> From: Colin Ian King <redacted>
>>
>> [drivers/video/fbdev/broadsheetfb.c:673]:
>>   (error) Memory leak: sector_buffer
>>
>> sector_buffer is not being kfree'd on each call to
>> broadsheet_spiflash_rewrite_sector(), so free it.
>>
>> Signed-off-by: Colin Ian King <redacted>
> 
> So you can make the box go OOM by repeatedly writing to the
> loadstore_waveform device attribute file?

..well, not quickly.

> Do we want this applied to -stable?
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

```