# \[PATCH\] fbdev: omap2: Fix typo in tvc\_probe\_pdata - Subsystems: FRAMEBUFFER LAYER, OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT (DSS2), THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2015/01/4402727/t ## \[PATCH\] fbdev: omap2: Fix typo in tvc\_probe\_pdata - From: Rasmus Villemoes \ - Date: 2015-01-05 13:10:11 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4402727.md ```text Assigning ddata->invert_polarity to itself is not very useful; the context suggests that the right-hand side should have been pdata->invert_polarity. Signed-off-by: Rasmus Villemoes --- drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c index 9a2b5ce58545..8511c648a15c 100644 --- a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c +++ b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c @@ -208,7 +208,7 @@ static int tvc_probe_pdata(struct platform_device *pdev) ddata->in = in; ddata->connector_type = pdata->connector_type; - ddata->invert_polarity = ddata->invert_polarity; + ddata->invert_polarity = pdata->invert_polarity; dssdev = &ddata->dssdev; dssdev->name = pdata->name; -- 2.1.3 ``` ## Re: \[PATCH\] fbdev: omap2: Fix typo in tvc\_probe\_pdata - From: Tomi Valkeinen \ - Date: 2015-01-13 11:26:59 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4408654.md ```text On 05/01/15 15:09, Rasmus Villemoes wrote: > Assigning ddata->invert_polarity to itself is not very useful; the > context suggests that the right-hand side should have been > pdata->invert_polarity. > > Signed-off-by: Rasmus Villemoes > --- > drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c > index 9a2b5ce58545..8511c648a15c 100644 > --- a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c > +++ b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c > @@ -208,7 +208,7 @@ static int tvc_probe_pdata(struct platform_device *pdev) > ddata->in = in; > > ddata->connector_type = pdata->connector_type; > - ddata->invert_polarity = ddata->invert_polarity; > + ddata->invert_polarity = pdata->invert_polarity; > > dssdev = &ddata->dssdev; > dssdev->name = pdata->name; Good catch, thanks! Queueing for 3.20 (as no one is using that flag in 3.19). Tomi ```