# \[PATCH\] fbdev: geocode: remove unneeded NULL check - Subsystems: FRAMEBUFFER LAYER, AMD GEODE PROCESSOR/CHIPSET SUPPORT, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2014/12/4401370/t ## \[PATCH\] fbdev: geocode: remove unneeded NULL check - From: Sudip Mukherjee \ - Date: 2014-12-31 06:55:51 - Message: https://ratatoskr.run/linux-fbdev/2014/12/4401370.md ```text the check for info is not required as we are checking it immediately after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/geode/gx1fb_core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c index 2794ba1..9bee874 100644 --- a/drivers/video/fbdev/geode/gx1fb_core.c +++ b/drivers/video/fbdev/geode/gx1fb_core.c @@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) release_mem_region(gx1_gx_base() + 0x8300, 0x100); } - if (info) { - fb_dealloc_cmap(&info->cmap); - framebuffer_release(info); - } + fb_dealloc_cmap(&info->cmap); + framebuffer_release(info); return ret; } -- 1.8.1.2 ``` ## Re: \[PATCH\] fbdev: geocode: remove unneeded NULL check - From: Tomi Valkeinen \ - Date: 2015-01-05 12:58:05 - Message: https://ratatoskr.run/linux-fbdev/2015/01/4402719.md ```text On 31/12/14 08:55, Sudip Mukherjee wrote: > the check for info is not required as we are checking it immediately > after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL. > > Signed-off-by: Sudip Mukherjee > --- > drivers/video/fbdev/geode/gx1fb_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c > index 2794ba1..9bee874 100644 > --- a/drivers/video/fbdev/geode/gx1fb_core.c > +++ b/drivers/video/fbdev/geode/gx1fb_core.c > @@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) > release_mem_region(gx1_gx_base() + 0x8300, 0x100); > } > > - if (info) { > - fb_dealloc_cmap(&info->cmap); > - framebuffer_release(info); > - } > + fb_dealloc_cmap(&info->cmap); > + framebuffer_release(info); > > return ret; > } > Thanks, queued for 3.20. Tomi ```