# Re: \[PATCH 1/1\] video: fbdev-LCDC: Deletion of an unnecessary check before the function call "vfree"

- From: Tomi Valkeinen \<hidden\>
- Date: 2014-12-04 14:19:29 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2014/12/4388963
- Thread: https://ratatoskr.run/linux-fbdev/2014/11/4380282/t.md

```text
Hi,

On 22/11/14 18:00, SF Markus Elfring wrote:
> From: Markus Elfring <redacted>
> Date: Sat, 22 Nov 2014 16:51:31 +0100
> 
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <redacted>
> ---
>  drivers/video/fbdev/sh_mobile_lcdcfb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
> index 2bcc84a..cfde21d 100644
> --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
> +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
> @@ -2181,8 +2181,7 @@ sh_mobile_lcdc_channel_fb_cleanup(struct sh_mobile_lcdc_chan *ch)
>  	if (!info || !info->device)
>  		return;
>  
> -	if (ch->sglist)
> -		vfree(ch->sglist);
> +	vfree(ch->sglist);
>  
>  	fb_dealloc_cmap(&info->cmap);
>  	framebuffer_release(info);

Thanks, I've applied the fbdev patches. Next time, please use
git-format-patch and git-send-email to send a proper patch series.

 Tomi


```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-fbdev/2014/12/4388963/attachment/0) (application/pgp-signature, 819 bytes)