# Re: \[PATCH\] Converting int usage to bool

- From: Tomi Valkeinen \<hidden\>
- Date: 2014-12-03 11:53:48 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2014/12/4387839
- Thread: https://ratatoskr.run/linux-fbdev/2014/11/4383803/t.md

```text
On 27/11/14 12:41, Quentin Lambert wrote:
> The following semantic patch was used to find
> functions and variables declared as int but
> used as boolean. The patch resulted in a
> significant number of false positive that I
> have ignored.
> 
> I am not hyper confident about the modification
> I made to the functions. Some of them seem to
> have quite significant side effects, which is not
> necesserarily intended from a boolean function.
> In particular both *_rwtest functions write data.
> Moreover sisfb_find_host_bridge name may suggest
> more than a boolean return.

I don't think I'm going to apply based on the above. I do like bools
where a boolean value is used, but changing it like this to a single
fbdev driver.. Well, I don't really see much benefit in this patch, and
there's a possibility for regressions.

 Tomi


```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-fbdev/2014/12/4387839/attachment/0) (application/pgp-signature, 819 bytes)