# \[patch\] OMAPDSS: pll: NULL dereference in error handling

- Subsystems: FRAMEBUFFER LAYER, OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT (DSS2), THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2014/12/13153421/t

## \[patch\] OMAPDSS: pll: NULL dereference in error handling

- From: Dan Carpenter \<hidden\>
- Date: 2014-12-16 23:54:42 
- Message: https://ratatoskr.run/linux-fbdev/2014/12/13153421.md

```text
The regulator_disable() doesn't accept NULL pointers.

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/video/fbdev/omap2/dss/pll.c b/drivers/video/fbdev/omap2/dss/pll.c
index 50bc62c5..335ffac 100644
--- a/drivers/video/fbdev/omap2/dss/pll.c
+++ b/drivers/video/fbdev/omap2/dss/pll.c
@@ -97,7 +97,8 @@ int dss_pll_enable(struct dss_pll *pll)
 	return 0;
 
 err_enable:
-	regulator_disable(pll->regulator);
+	if (pll->regulator)
+		regulator_disable(pll->regulator);
 err_reg:
 	clk_disable_unprepare(pll->clkin);
 	return r;
```

## Re: \[patch\] OMAPDSS: pll: NULL dereference in error handling

- From: Tomi Valkeinen \<hidden\>
- Date: 2014-12-17 06:28:56 
- Message: https://ratatoskr.run/linux-fbdev/2014/12/13153422.md

```text
On 17/12/14 01:54, Dan Carpenter wrote:
> The regulator_disable() doesn't accept NULL pointers.
> 
> Signed-off-by: Dan Carpenter <redacted>
> 
> diff --git a/drivers/video/fbdev/omap2/dss/pll.c b/drivers/video/fbdev/omap2/dss/pll.c
> index 50bc62c5..335ffac 100644
> --- a/drivers/video/fbdev/omap2/dss/pll.c
> +++ b/drivers/video/fbdev/omap2/dss/pll.c
> @@ -97,7 +97,8 @@ int dss_pll_enable(struct dss_pll *pll)
>  	return 0;
>  
>  err_enable:
> -	regulator_disable(pll->regulator);
> +	if (pll->regulator)
> +		regulator_disable(pll->regulator);
>  err_reg:
>  	clk_disable_unprepare(pll->clkin);
>  	return r;
> 

Thanks! Queuing for 3.19 fbdev fixes.

 Tomi


```