Re: [PATCH 02/15] GPIO: port LoCoMo gpio support from old driver

On Tue, Nov 11, 2014 at 2:16 PM, Dmitry Eremin-Solenikov
[off-list ref] wrote:

Just to better understand your suggestions: do you want me to convert
to regmap only gpio driver or do you suggest to convert all LoCoMo drivers?

Um... I was just thinking about this one usecase.

It's no big deal, the other review comments are more important.

That is doable, of course, but the amount of changes is overwhelming.
Also I'm concerned about the performance impact from going through
regmap layers.

Is it on a critical path? The current locking isn't any less invasive
AFAICT.

Yours,
Linus Walleij

2014-11-14 13:11 GMT+03:00 Linus Walleij [off-list ref]:

On Tue, Nov 11, 2014 at 2:16 PM, Dmitry Eremin-Solenikov
[off-list ref] wrote:

quoted

Just to better understand your suggestions: do you want me to convert
to regmap only gpio driver or do you suggest to convert all LoCoMo drivers?

Um... I was just thinking about this one usecase.

I ended up converting all drivers. It allowed me to clean up several points
in the driver.

It's no big deal, the other review comments are more important.

Fixed most of the comments. Last remaining issue is factoring out m62332
interface.

quoted

That is doable, of course, but the amount of changes is overwhelming.
Also I'm concerned about the performance impact from going through
regmap layers.

Is it on a critical path? The current locking isn't any less invasive
AFAICT.

Yours,
Linus Walleij

-- 
With best wishes
Dmitry