# \[PATCH 1/1\] video: uvesafb: Deletion of an unnecessary check before the function call "uvesafb\_free"

- Subsystems: FRAMEBUFFER LAYER, UVESAFB DRIVER, THE REST
- Maintainers: Helge Deller, Michal Januszewski, Linus Torvalds
- List: linux-fbdev
- 1 message, 1 author
- Page: https://ratatoskr.run/linux-fbdev/2014/11/4380383/t

## \[PATCH 1/1\] video: uvesafb: Deletion of an unnecessary check before the function call "uvesafb\_free"

- From: SF Markus Elfring \<hidden\>
- Date: 2014-11-23 10:11:57 
- Message: https://ratatoskr.run/linux-fbdev/2014/11/4380383.md

```text
From: Markus Elfring <redacted>
Date: Sun, 23 Nov 2014 11:00:26 +0100

The uvesafb_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/video/fbdev/uvesafb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index 509d452..f718627 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1219,8 +1219,7 @@ static int uvesafb_release(struct fb_info *info, int user)
 	uvesafb_vbe_state_restore(par, par->vbe_state_orig);
 out:
 	atomic_dec(&par->ref_count);
-	if (task)
-		uvesafb_free(task);
+	uvesafb_free(task);
 	return 0;
 }
 
-- 
2.1.3

```