Re: [PATCH] fbcon: Fix option parsing control flow in fb_console_setup
From: Tomi Valkeinen <hidden>
Date: 2014-10-22 06:54:07
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Tomi Valkeinen <hidden>
Date: 2014-10-22 06:54:07
Also in:
lkml
On 09/10/14 12:48, Maarten ter Huurne wrote:
Since strsep is used to tokenize the options string, after each option match the code should use "continue" to get the next token from strsep. This patch applies this pattern consistently. Previously, for "scrollback:" and "map:" the parse code would return (unconditionally: strsep ensures *options != ','), causing any following option to be ignored, while for "vc:" the parse code would go on to parse further options within the same token, which could lead to invalid input being accepted. Signed-off-by: Maarten ter Huurne <redacted> Acked-by: Paul Cercueil <paul@crapouillou.net> --- drivers/video/console/fbcon.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)
Thanks, queued for 3.18 fixes. Tomi