# \[PATCH 00/12\] dmaengine: remove users of device\_control

- Subsystems: FRAMEBUFFER LAYER, DMA GENERIC OFFLOAD ENGINE SUBSYSTEM, LIBATA PATA ARASAN COMPACT FLASH CONTROLLER, LIBATA SUBSYSTEM (Serial and Parallel ATA drivers), MEDIA INPUT INFRASTRUCTURE (V4L/DVB), MEMORY TECHNOLOGY DEVICES (MTD), MICROCHIP SPI DRIVER, MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER, NAND FLASH SUBSYSTEM, NETWORKING DRIVERS, SOUND, SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC), SPI SUBSYSTEM, THE REST, TTY LAYER AND SERIAL DRIVERS, USB SUBSYSTEM
- Maintainers: Helge Deller, Vinod Koul, Viresh Kumar, Damien Le Moal, Niklas Cassel, Mauro Carvalho Chehab, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra, Ryan Wanner, Bin Liu, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Mark Brown, Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
- Series: 12 patches touching 12 files, +20/-34
- List: linux-fbdev
- 3 messages, 1 author
- Page: https://ratatoskr.run/linux-fbdev/2014/10/4351035/t

## \[PATCH 00/12\] dmaengine: remove users of device\_control

- From: Vinod Koul \<hidden\>
- Date: 2014-10-11 16:14:14 
- Message: https://ratatoskr.run/linux-fbdev/2014/10/4351035.md

```text
The recent discussion [1] on the API have resulted in moving away from
device_control ioctl method to proper channel APIs.
There are still few users on the device_control which should use the wrappers
existing rather than access device_control.
This will aid us in deprecating and removing device_control, possibly after
the merge window.

These can be merged thru respective subsystem tree or dmaengine tree. Either
way please just let me know.

Feng's kbuild has tested these as well [2]

[1]: http://www.spinics.net/lists/dmaengine/msg02212.html
[2]: http://git.infradead.org/users/vkoul/slave-dma.git/shortlog/refs/heads/topic/dma_control_cleanup

Vinod Koul (12):
  pata_arasan_cf: use dmaengine_terminate_all() API
  dmaengine: coh901318: use dmaengine_terminate_all() API
  [media] V4L2: mx3_camer: use dmaengine_pause() API
  mtd: fsmc_nand: use dmaengine_terminate_all() API
  mtd: sh_flctl: use dmaengine_terminate_all() API
  net: ks8842: use dmaengine_terminate_all() API
  spi/atmel: use dmaengine_terminate_all() API
  spi/spi-dw-mid.c: use dmaengine_slave_config() API
  serial: sh-sci: use dmaengine_terminate_all() API
  usb: musb: ux500_dma: use dmaengine_xxx() APIs
  ASoC: txx9: use dmaengine_terminate_all() API
  video: mx3fb: use dmaengine_terminate_all() API

 drivers/ata/pata_arasan_cf.c                   |    5 ++---
 drivers/dma/coh901318.c                        |    2 +-
 drivers/media/platform/soc_camera/mx3_camera.c |    6 ++----
 drivers/mtd/nand/fsmc_nand.c                   |    2 +-
 drivers/mtd/nand/sh_flctl.c                    |    2 +-
 drivers/net/ethernet/micrel/ks8842.c           |    6 ++----
 drivers/spi/spi-atmel.c                        |    6 ++----
 drivers/spi/spi-dw-mid.c                       |    6 ++----
 drivers/tty/serial/sh-sci.c                    |    2 +-
 drivers/usb/musb/ux500_dma.c                   |    7 ++-----
 drivers/video/fbdev/mx3fb.c                    |    3 +--
 sound/soc/txx9/txx9aclc.c                      |    7 +++----
 12 files changed, 20 insertions(+), 34 deletions(-)

```

## \[PATCH 12/12\] video: mx3fb: use dmaengine\_terminate\_all() API

- From: Vinod Koul \<hidden\>
- Date: 2014-10-11 16:15:37 
- Message: https://ratatoskr.run/linux-fbdev/2014/10/4351043.md

```text
The drivers should use dmaengine_terminate_all() API instead of
accessing the device_control which will be deprecated soon

Signed-off-by: Vinod Koul <redacted>
---
 drivers/video/fbdev/mx3fb.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
index c645a0a..cdbc93a 100644
--- a/drivers/video/fbdev/mx3fb.c
+++ b/drivers/video/fbdev/mx3fb.c
@@ -461,8 +461,7 @@ static void sdc_disable_channel(struct mx3fb_info *mx3_fbi)
 
 	spin_unlock_irqrestore(&mx3fb->lock, flags);
 
-	mx3_fbi->txd->chan->device->device_control(mx3_fbi->txd->chan,
-						   DMA_TERMINATE_ALL, 0);
+	dmaengine_terminate_all(mx3_fbi->txd->chan);
 	mx3_fbi->txd = NULL;
 	mx3_fbi->cookie = -EINVAL;
 }
-- 
1.7.0.4

```

## Re: \[PATCH 00/12\] dmaengine: remove users of device\_control

- From: Vinod Koul \<hidden\>
- Date: 2014-10-15 16:34:09 
- Message: https://ratatoskr.run/linux-fbdev/2014/10/4352893.md

```text
On Sat, Oct 11, 2014 at 09:09:33PM +0530, Vinod Koul wrote:
> The recent discussion [1] on the API have resulted in moving away from
> device_control ioctl method to proper channel APIs.
> There are still few users on the device_control which should use the wrappers
> existing rather than access device_control.
> This will aid us in deprecating and removing device_control, possibly after
> the merge window.
> 
> These can be merged thru respective subsystem tree or dmaengine tree. Either
> way please just let me know.

Applying to dmaengine-next with acks recived, dropping the ones which are
applied by respective folks

-- 
~Vinod

> 
> Feng's kbuild has tested these as well [2]
> 
> [1]: http://www.spinics.net/lists/dmaengine/msg02212.html
> [2]: http://git.infradead.org/users/vkoul/slave-dma.git/shortlog/refs/heads/topic/dma_control_cleanup
> 
> Vinod Koul (12):
>   pata_arasan_cf: use dmaengine_terminate_all() API
>   dmaengine: coh901318: use dmaengine_terminate_all() API
>   [media] V4L2: mx3_camer: use dmaengine_pause() API
>   mtd: fsmc_nand: use dmaengine_terminate_all() API
>   mtd: sh_flctl: use dmaengine_terminate_all() API
>   net: ks8842: use dmaengine_terminate_all() API
>   spi/atmel: use dmaengine_terminate_all() API
>   spi/spi-dw-mid.c: use dmaengine_slave_config() API
>   serial: sh-sci: use dmaengine_terminate_all() API
>   usb: musb: ux500_dma: use dmaengine_xxx() APIs
>   ASoC: txx9: use dmaengine_terminate_all() API
>   video: mx3fb: use dmaengine_terminate_all() API
> 
>  drivers/ata/pata_arasan_cf.c                   |    5 ++---
>  drivers/dma/coh901318.c                        |    2 +-
>  drivers/media/platform/soc_camera/mx3_camera.c |    6 ++----
>  drivers/mtd/nand/fsmc_nand.c                   |    2 +-
>  drivers/mtd/nand/sh_flctl.c                    |    2 +-
>  drivers/net/ethernet/micrel/ks8842.c           |    6 ++----
>  drivers/spi/spi-atmel.c                        |    6 ++----
>  drivers/spi/spi-dw-mid.c                       |    6 ++----
>  drivers/tty/serial/sh-sci.c                    |    2 +-
>  drivers/usb/musb/ux500_dma.c                   |    7 ++-----
>  drivers/video/fbdev/mx3fb.c                    |    3 +--
>  sound/soc/txx9/txx9aclc.c                      |    7 +++----
>  12 files changed, 20 insertions(+), 34 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
```
