[PATCH 1/1] video: vermilion: remove unnecessary break after goto

Subsystems: framebuffer layer, the rest

STALE4425d

2 messages, 2 authors, 2014-08-26 · open the first message on its own page

[PATCH 1/1] video: vermilion: remove unnecessary break after goto

From: Fabian Frederick <hidden>
Date: 2014-07-08 16:27:31

Cc: Jean-Christophe Plagniol-Villard <redacted>
Cc: Tomi Valkeinen <redacted>
Cc: Jingoo Han <redacted>
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Fabian Frederick <redacted>
---
 drivers/video/fbdev/vermilion/vermilion.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vermilion/vermilion.c b/drivers/video/fbdev/vermilion/vermilion.c
index 048a666..5f930ae 100644
--- a/drivers/video/fbdev/vermilion/vermilion.c
+++ b/drivers/video/fbdev/vermilion/vermilion.c
@@ -481,7 +481,6 @@ static int vml_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 	default:
 		err = -ENODEV;
 		goto out_err_1;
-		break;
 	}
 
 	info = &vinfo->info;
-- 
1.8.4.5

Re: [PATCH 1/1] video: vermilion: remove unnecessary break after goto

From: Tomi Valkeinen <hidden>
Date: 2014-08-26 12:41:15

On 08/07/14 19:27, Fabian Frederick wrote:
quoted hunk
Cc: Jean-Christophe Plagniol-Villard <redacted>
Cc: Tomi Valkeinen <redacted>
Cc: Jingoo Han <redacted>
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Fabian Frederick <redacted>
---
 drivers/video/fbdev/vermilion/vermilion.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vermilion/vermilion.c b/drivers/video/fbdev/vermilion/vermilion.c
index 048a666..5f930ae 100644
--- a/drivers/video/fbdev/vermilion/vermilion.c
+++ b/drivers/video/fbdev/vermilion/vermilion.c
@@ -481,7 +481,6 @@ static int vml_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 	default:
 		err = -ENODEV;
 		goto out_err_1;
-		break;
 	}
 
 	info = &vinfo->info;
Thanks, queued for 3.18.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help