[PATCH v2] video: fbdev: sis: init.c: Cleaning up redundant condition is always true
DORMANTno replies
From: Rickard Strandqvist <hidden>
Date: 2014-07-07 20:55:09
Also in:
lkml
Subsystem:
framebuffer layer, sis framebuffer driver, the rest · Maintainers:
Helge Deller, Linus Torvalds
Find a redundant condition that is always true, that after some discussions prove to be that wrong variable that was checked. Signed-off-by: Rickard Strandqvist <redacted> --- drivers/video/fbdev/sis/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
index bd40f5e..dc9613a 100644
--- a/drivers/video/fbdev/sis/init.c
+++ b/drivers/video/fbdev/sis/init.c@@ -355,12 +355,12 @@ SiS_GetModeID(int VGAEngine, unsigned int VBFlags, int HDisplay, int VDisplay, } break; case 400: - if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 800) && (LCDwidth >= 600))) { + if ((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 800) && (LCDheight >= 600))) { if(VDisplay = 300) ModeIndex = ModeIndex_400x300[Depth]; } break; case 512: - if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 1024) && (LCDwidth >= 768))) { + if ((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 1024) && (LCDheight >= 768))) { if(VDisplay = 384) ModeIndex = ModeIndex_512x384[Depth]; } break;
--
1.7.10.4