# \[PATCH\] video: fbdev: vga16fb.c: Cleaning up useless assignment of function parameter

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 1 message, 1 author
- Page: https://ratatoskr.run/linux-fbdev/2014/07/4287909/t

## \[PATCH\] video: fbdev: vga16fb.c: Cleaning up useless assignment of function parameter

- From: Rickard Strandqvist \<hidden\>
- Date: 2014-07-06 17:25:24 
- Message: https://ratatoskr.run/linux-fbdev/2014/07/4287909.md

```text
Remove assignment of function parameter, that has no effect outside the function

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/vga16fb.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 283d335..d92e4fd 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -275,7 +275,6 @@ static void vga16fb_clock_chip(struct vga16fb_par *par,
 	}
 	par->misc |= best->misc;
 	par->clkdiv = best->seq_clock_mode;
-	pixclock = (best->pixclock * div) / mul;		
 }
 			       
 #define FAIL(X) return -EINVAL
-- 
1.7.10.4

```
