[PATCH] video: fbdev: core: fbmon.c: Cleaning up useless assignment of function parameter

Remove assignment of function parameter, that has no effect outside the function

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/core/fbmon.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index 5b0e313..71ec1ab 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c

@@ -1481,7 +1481,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var)
 }
 void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
 {
-	specs = NULL;
 }
 void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs)
 {

-- 
1.7.10.4

On Sun, Jul 6, 2014 at 7:25 PM, Rickard Strandqvist
[off-list ref] wrote:

I guess the intention was:

memset(specs, 0, sizeof(struct fb_monspecs));

 }
 void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs)
 {

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

2014-07-07 22:43 GMT+02:00 Geert Uytterhoeven [off-list ref]:

On Sun, Jul 6, 2014 at 7:25 PM, Rickard Strandqvist
[off-list ref] wrote:

quoted

Remove assignment of function parameter, that has no effect outside the function

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/core/fbmon.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index 5b0e313..71ec1ab 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c

@@ -1481,7 +1481,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var)
 }
 void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
 {
-       specs = NULL;

I guess the intention was:

memset(specs, 0, sizeof(struct fb_monspecs));

Hi Geert!

Yeah, maybe. Just looks to be a little too elementary mistake..?

But do you want me to change it to that?

With a:
if(specs)
  memset()

maybe..?


Kind regards
Rickard Strandqvist