# \[PATCH\] video: fbdev: sis: sis\_main.c: Cleaning up wrong type in format string

- Subsystems: FRAMEBUFFER LAYER, SIS FRAMEBUFFER DRIVER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 1 message, 1 author
- Page: https://ratatoskr.run/linux-fbdev/2014/07/4287714/t

## \[PATCH\] video: fbdev: sis: sis\_main.c: Cleaning up wrong type in format string

- From: Rickard Strandqvist \<hidden\>
- Date: 2014-07-05 13:17:22 
- Message: https://ratatoskr.run/linux-fbdev/2014/07/4287714.md

```text
From: Rickard Strandqvist <redacted>

Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/sis/sis_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 22ad028..ab7e5e4 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -237,7 +237,7 @@ static void sisfb_get_vga_mode_from_kernel(void)
 
 		if(mydepth = 24) mydepth = 32;
 
-		sprintf(mymode, "%ux%ux%u", screen_info.lfb_width,
+		sprintf(mymode, "%ux%ux%d", screen_info.lfb_width,
 					screen_info.lfb_height,
 					mydepth);
 
-- 
1.7.10.4

```
