[PATCH] video: fbdev: valkyriefb.c: Cleaning up variable that is never used

From: Rickard Strandqvist <redacted>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/valkyriefb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
index 97cb9bd..af708fe 100644
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c

@@ -416,18 +416,18 @@ static int read_valkyrie_sense(struct fb_info_valkyrie *p)
 
 	out_8(&p->valkyrie_regs->msense.r, 0);   /* release all lines */
 	__delay(20000);
-	sense = ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x70) << 4;
+	sense = ((in_8(&p->valkyrie_regs->msense.r)) & 0x70) << 4;
 	/* drive each sense line low in turn and collect the other 2 */
 	out_8(&p->valkyrie_regs->msense.r, 4);   /* drive A low */
 	__delay(20000);
-	sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x30);
+	sense |= ((in_8(&p->valkyrie_regs->msense.r)) & 0x30);
 	out_8(&p->valkyrie_regs->msense.r, 2);   /* drive B low */
 	__delay(20000);
 	sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x40) >> 3;
 	sense |= (in & 0x10) >> 2;
 	out_8(&p->valkyrie_regs->msense.r, 1);   /* drive C low */
 	__delay(20000);
-	sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x60) >> 5;
+	sense |= ((in_8(&p->valkyrie_regs->msense.r)) & 0x60) >> 5;
 
 	out_8(&p->valkyrie_regs->msense.r, 7);
 

-- 
1.7.10.4

On Sat, Jul 5, 2014 at 2:52 PM, Rickard Strandqvist
[off-list ref] wrote:

From: Rickard Strandqvist <redacted>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds