[PATCH V2] video: fbdev: matrox: matroxfb_base.c: Cleaning up a null pointer checks that could never happen

Subsystems: framebuffer layer, matrox framebuffer driver, the rest

STALE4490d

2 messages, 2 authors, 2014-07-03 · open the first message on its own page

[PATCH V2] video: fbdev: matrox: matroxfb_base.c: Cleaning up a null pointer checks that could never happen

From: Rickard Strandqvist <hidden>
Date: 2014-07-03 19:15:03

Removal of null pointer checks that could never happen

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/matrox/matroxfb_base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
index 7116c53..cd9dc88 100644
--- a/drivers/video/fbdev/matrox/matroxfb_base.c
+++ b/drivers/video/fbdev/matrox/matroxfb_base.c
@@ -1973,7 +1973,7 @@ static void matroxfb_register_device(struct matrox_fb_info* minfo) {
 	for (drv = matroxfb_driver_l(matroxfb_driver_list.next);
 	     drv != matroxfb_driver_l(&matroxfb_driver_list);
 	     drv = matroxfb_driver_l(drv->node.next)) {
-		if (drv && drv->probe) {
+		if (drv->probe) {
 			void *p = drv->probe(minfo);
 			if (p) {
 				minfo->drivers_data[i] = p;
-- 
1.7.10.4

Re: [PATCH V2] video: fbdev: matrox: matroxfb_base.c: Cleaning up a null pointer checks that could never happen

From: Mikulas Patocka <mpatocka@redhat.com>
Date: 2014-07-03 20:47:53

Acked-by: Mikulas Patocka <mpatocka@redhat.com>

On Thu, 3 Jul 2014, Rickard Strandqvist wrote:
quoted hunk
Removal of null pointer checks that could never happen

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/matrox/matroxfb_base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
index 7116c53..cd9dc88 100644
--- a/drivers/video/fbdev/matrox/matroxfb_base.c
+++ b/drivers/video/fbdev/matrox/matroxfb_base.c
@@ -1973,7 +1973,7 @@ static void matroxfb_register_device(struct matrox_fb_info* minfo) {
 	for (drv = matroxfb_driver_l(matroxfb_driver_list.next);
 	     drv != matroxfb_driver_l(&matroxfb_driver_list);
 	     drv = matroxfb_driver_l(drv->node.next)) {
-		if (drv && drv->probe) {
+		if (drv->probe) {
 			void *p = drv->probe(minfo);
 			if (p) {
 				minfo->drivers_data[i] = p;
-- 
1.7.10.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help