[PATCH] video: fbdev: sis: init301.c: Cleaning up a potential division by zero

STALE4489d

2 messages, 1 author, 2014-07-02 · open the first message on its own page

[PATCH] video: fbdev: sis: init301.c: Cleaning up a potential division by zero

From: Rickard Strandqvist <hidden>
Date: 2014-07-02 22:07:23

Guess these ifdef will always be set, but still feel that 1 is a better starting value other than 0 in this case.

This was found using a static code analysis program called cppcheck

Rickard Strandqvist (1):
  video: fbdev: sis: init301.c:  Cleaning up a potential division by zero

 drivers/video/fbdev/sis/init301.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH] video: fbdev: sis: init301.c: Cleaning up a potential division by zero

From: Rickard Strandqvist <hidden>
Date: 2014-07-02 22:07:28

Cleaning up a potential division by zero.

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/sis/init301.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c
index a89e3ca..730be06 100644
--- a/drivers/video/fbdev/sis/init301.c
+++ b/drivers/video/fbdev/sis/init301.c
@@ -5351,7 +5351,7 @@ SiS_SetGroup1_LVDS(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned s
 {
   unsigned short modeflag, resinfo = 0;
   unsigned short push2, tempax, tempbx, tempcx, temp;
-  unsigned int   tempeax = 0, tempebx, tempecx, tempvcfact = 0;
+  unsigned int   tempeax = 0, tempebx, tempecx, tempvcfact = 1;
   bool islvds = false, issis  = false, chkdclkfirst = false;
 #ifdef CONFIG_FB_SIS_300
   unsigned short crt2crtc = 0;
-- 
1.7.10.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help