# Re: \[PATCH\] pwm-backlight: use devm\_gpiod\_get\_optional()

- From: Lee Jones \<hidden\>
- Date: 2014-06-25 09:54:58 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2014/06/4280833
- Thread: https://ratatoskr.run/linux-fbdev/2014/06/4280797/t.md

```text
> Make use of the new devm_gpiod_get_optional() to simplify the probe
> code.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>  drivers/video/backlight/pwm_bl.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Looks good.  Applied, thanks.

> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 38ca88bc5c3e..d1e0a7c6cac7 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -245,13 +245,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>  	pb->dev = &pdev->dev;
>  	pb->enabled = false;
>  
> -	pb->enable_gpio = devm_gpiod_get(&pdev->dev, "enable");
> +	pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
>  	if (IS_ERR(pb->enable_gpio)) {
>  		ret = PTR_ERR(pb->enable_gpio);
> -		if (ret = -ENOENT)
> -			pb->enable_gpio = NULL;
> -		else
> -			goto err_alloc;
> +		goto err_alloc;
>  	}
>  
>  	/*

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
```