# \[patch\] video/mbx: indent some if statements

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2014/06/13153162/t

## \[patch\] video/mbx: indent some if statements

- From: Dan Carpenter \<hidden\>
- Date: 2014-06-11 06:45:35 
- Message: https://ratatoskr.run/linux-fbdev/2014/06/13153162.md

```text
Checkpatch.pl worries that we have left off the conditional bit because
it isn't indented correctly.

WARNING: suspect code indent for conditional statements (24, 24)

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
index 2bd52ed..698df954 100644
--- a/drivers/video/fbdev/mbx/mbxfb.c
+++ b/drivers/video/fbdev/mbx/mbxfb.c
@@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
 		case MBXFB_IOCS_PLANEORDER:
 			if (copy_from_user(&porder, (void __user*)arg,
 					sizeof(struct mbxfb_planeorder)))
-			return -EFAULT;
+				return -EFAULT;
 
 			return mbxfb_ioctl_planeorder(&porder);
 
 		case MBXFB_IOCS_ALPHA:
 			if (copy_from_user(&alpha, (void __user*)arg,
 					sizeof(struct mbxfb_alphaCtl)))
-			return -EFAULT;
+				return -EFAULT;
 
 			return mbxfb_ioctl_alphactl(&alpha);
 
```

## Re: \[patch\] video/mbx: indent some if statements

- From: Tomi Valkeinen \<hidden\>
- Date: 2014-06-23 11:51:42 
- Message: https://ratatoskr.run/linux-fbdev/2014/06/13153163.md

```text
On 11/06/14 09:45, Dan Carpenter wrote:
> Checkpatch.pl worries that we have left off the conditional bit because
> it isn't indented correctly.
> 
> WARNING: suspect code indent for conditional statements (24, 24)
> 
> Signed-off-by: Dan Carpenter <redacted>
> 
> diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
> index 2bd52ed..698df954 100644
> --- a/drivers/video/fbdev/mbx/mbxfb.c
> +++ b/drivers/video/fbdev/mbx/mbxfb.c
> @@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
>  		case MBXFB_IOCS_PLANEORDER:
>  			if (copy_from_user(&porder, (void __user*)arg,
>  					sizeof(struct mbxfb_planeorder)))
> -			return -EFAULT;
> +				return -EFAULT;
>  
>  			return mbxfb_ioctl_planeorder(&porder);
>  
>  		case MBXFB_IOCS_ALPHA:
>  			if (copy_from_user(&alpha, (void __user*)arg,
>  					sizeof(struct mbxfb_alphaCtl)))
> -			return -EFAULT;
> +				return -EFAULT;
>  
>  			return mbxfb_ioctl_alphactl(&alpha);
>  
> 

Thanks, queued for 3.17.

 Tomi


```
